23

How can I get this error from with in the DownloadStringCompleted Event? Doesn't that mean, it's finished? Is there another event I can fire this from?

I get this error extremely rarely, but once in a while it will happen on my WP7 phone. I have a web client that I fire over and over, and I fire it again from the completed event. Is this happening because there is still some stale connection open? Is there a way to prevent this 100%?

I have checked to see if there is a chance for the thread to walk over itself, but it is only fired from within the completed event.

How can I be sure, when the complete event is fired, the client is no longer isBusy? One suggestion was to add a while with a thread sleep while the client is busy.

Some pseudo code.

var client = new WebClient("URL 1");
client.CompletedEvent += CompletedEvent;
client.downloadasync();

void CompletedEvent(){
Dosomestuff;
client.downloadasync(); //This is where we break.
}
firebellys
  • 886
  • 2
  • 11
  • 26

5 Answers5

20

The WebClient only supports a single operations, it cannot download multiple files. You haven't shown your code, but my guess is that you are somehow firing a new request before the old is completed. My bet is that WebClient.IsBusy is true when you attempt to perform another fetch.

See the following thread:

wb.DownloadFileAsync throw "WebClient does not support concurrent I/O operations." exception

Community
  • 1
  • 1
ColinE
  • 66,765
  • 14
  • 157
  • 225
  • 1
    My point is I never call downloadasync unless i'm in the completed event. Shouldn't the connection be closed and client free if I'm in that event? If this isn't the case, how can I avoid it other than to use IsBusy? – firebellys Mar 19 '12 at 07:12
  • Yes, this thread is telling me to do exactly what am I doing now and I am getting the error. I will add some more information above. – firebellys Mar 20 '12 at 07:50
  • 1
    Just to save anyone the bother, that answer posted above just links to here: http://stackoverflow.com/questions/2042258/webclient-downloadfileasync-download-files-one-at-a-time – TEK May 11 '16 at 16:20
  • I have the same issue and I am waiting to have client.IsBusy = false before puting the client back in the BlockingCollection – sofsntp Sep 26 '17 at 16:44
10

The only answer is to create a new webclient within the scope of the Completed Event. You can't set it to new since webclient is readonly. Creating a new client is the only solution. This allows the old client to complete in the background. This does have slight memory implications since you are creating a new instance instead of reusing an old. But the garbage collector should keep it clean if your scope is setup right.

firebellys
  • 886
  • 2
  • 11
  • 26
8

Instead of using WebClient use HttpClient to do parallel HTTP calls. Below code shows how to download files.

        HttpClient httpClient = new HttpClient();
        var documentList=_documentManager.GetAllDocuments();
        documentList.AsParallel().ForAll(doc =>
        {

            var responseResult= httpClient.GetAsync(doc.FileURLPath);
            using (var memStream = responseResult.Result.Content.ReadAsStreamAsync().Result)
            {
                using (var fileStream =File.Create($"{filePath}\\{doc.FileName}"))
                {
                    memStream.CopyTo(fileStream);
                }

            }
        });
Ahamed Ishak
  • 812
  • 11
  • 15
0

The solution, I found is to use multiple WebClient objects, so to modify your pseudocode example; try

var client = new WebClient("URL 1");
client.CompletedEvent += CompletedEvent;
client.downloadasync();

void CompletedEvent(){
Dosomestuff;
var client2 = new WebClient();
client2.downloadasync(); 
}
Fiach Reid
  • 4,811
  • 2
  • 27
  • 33
0

Create a new Web Client for each new request. Don't reuse an existing Web Client instance.

This allows the first request to complete before starting the new one. This is a standard way of creating new requests.

nixish
  • 21
  • 3