How to fix Warning: mysql_fetch_array() expects parameter 1 to be resource, boolean given in?

Question

Possible Duplicate:
PHP: Warning: sort() expects parameter 1 to be array, resource given

I keep getting the following message Warning: mysql_fetch_array() expects parameter 1 to be resource, boolean given in C:\xampp\htdocs\test\test.class.php on line 22 But when i check the code i can't see what is wrong...

<?php
// Main menu items
$sql=mysql_query("SELECT * FROM category WHERE tier='1' ORDER BY id ASC");
while($row = mysql_fetch_array($sql)){      
    $p_id= $row["id"];
    $p_category_name= $row["category_name"];
    $mainMenu[''.$p_category_name.'']= $p_id;

    $sql_1=mysql_query("SELECT * FROM category WHERE tier='2' parent='$p_id' ORDER BY id ASC");
    while($row_1 = mysql_fetch_array($sql_1)){ **This is line 22**
        $c_id= $row_1["id"];
        $c_category_name= $row_1["category_name"];
        $subMenu[''.$p_category_name.''][''.$c_category_name.''] = 'product1.php';
    } 

}

Your `mysql_query` is probably generating a MySQL error, but you don't seem to have any error handling code. Try adding some first, for example by checking if the return value of `mysql_query` evaluates to `true` and if not, show or log the output of `mysql_error`. — Another Code, Mar 10 '12 at 17:04
@AnotherCode although you are right in general, mysql error messages are quite vague and can help a little — Your Common Sense, Mar 10 '12 at 17:13

score 3 · Answer 1 · answered Mar 10 '12 at 17:05

3

You have an error in your query (forgot the and). Try this

SELECT * FROM category WHERE tier='2' and parent='$p_id' ORDER BY id ASC

answered Mar 10 '12 at 17:05

juergen d

195,137
36
275
343

score 3 · Accepted Answer · answered Mar 10 '12 at 17:05

3

This means mysql_query failed to execute the query, and you should use mysql_error() to see the error message.

In this case, it looks like you're missing an AND:

$sql_1=mysql_query("SELECT * FROM category WHERE tier='2' AND parent='$p_id' ORDER BY id ASC");

(And please look into PDO.)

answered Mar 10 '12 at 17:05

DCoder

12,740
4
42
61

+1 ... and not PDO yet, PDO is not good for beginners. He must learn some mysql basics first :) – Wh1T3h4Ck5 Mar 10 '12 at 17:20
thanks for the link i'll go and check it out – JimmyV Mar 10 '12 at 17:22

score 2 · Answer 3 · edited Mar 10 '12 at 17:10

2

You've got an SQL syntax error:

$sql_1=mysql_query("SELECT * FROM category WHERE tier='2' parent='$p_id' ORDER BY id ASC");
                                                         ^-- missing ' AND '

If you had proper error handling in your code, you've have seen this:

$sql_1 = mysql_query(...) or trigger_error(mysql_error());
                         ^^^^^^^^^^^^^^^^^^^^^^--- bare mininum handling

NEVER assume a query has succeeded.

edited Mar 10 '12 at 17:10

Your Common Sense

154,967
38
205
325

answered Mar 10 '12 at 17:05

Marc B

348,685
41
398
480

Thanks for the quick responce. I am new to all this and i lack a lot of knowledge, i will try to keep that in my mind – JimmyV Mar 10 '12 at 17:09

score 1 · Answer 4 · answered Mar 10 '12 at 17:06

AND is missing from the query in the WHERE clause

    $sql_1=mysql_query("SELECT * FROM category WHERE tier='2'  parent='$p_id' ORDER BY id ASC");

it should be:

    $sql_1=mysql_query("SELECT * FROM category WHERE tier='2' AND parent='$p_id' ORDER BY id ASC");

GaminGrounds · Answer 5 · 2012-03-10T17:23:41.620

Try making $row an array:

while($row[] = mysql_fetch_array($sql))

make sure all your queries are like this:

$sql = mysql_query("SELECT * FROM category WHERE tier='1' ORDER BY id ASC") or die(mysql_error());

http://php.net/manual/en/function.mysql-fetch-array.php

Additionally I think your supposed to be using mysql_fetch_assoc(); http://www.php.net/manual/en/function.mysql-fetch-assoc.php

Try this:

$sql = "SELECT * FROM category WHERE tier='1' ORDER BY id ASC";
$fetch = mysql_fetch_assoc(mysql_query($sql)) or die(mysql_error());
while ($row = $fetch) {
    $p_id = $row["id"];
    $p_category_name = $row["category_name"];
    $mainMenu[''.$p_category_name.'']= $p_id;

    $sql_1 = "SELECT * FROM category WHERE tier='2' AND parent='$p_id' ORDER BY id ASC";
    $fetch_1 = mysql_fetch_assoc(mysql_query($sql_1)) or die(mysql_error());
    while ($row_1 = $fetch_1) {
        $c_id = $row_1["id"];
        $c_category_name = $row_1["category_name"];
        $subMenu[''.$p_category_name.''][''.$c_category_name.''] = 'product1.php';
    } 
}

score -4 · Answer 6 · answered Mar 10 '12 at 17:05

-4

Remove quotes from numerics.

Tier=1

plus check your sql by running in phpmyadmin to check whether it runs or not.

answered Mar 10 '12 at 17:05

itachi

6,072
3
29
40

How to fix Warning: mysql_fetch_array() expects parameter 1 to be resource, boolean given in?

6 Answers6