Check if file exists and continue else exit in Bash

Question

I have a script that is one script in a chain of others that sends an email.

At the start of the script I want to check if a file exists and continue only if it exists, otherwise just quit.

Here is the start of my script:

if [ ! -f /scripts/alert ];
then
    echo "File not found!" && exit 0
else
        continue
fi

However I keep getting a message saying:

line 10: continue: only meaningful in a `for', `while', or `until' loop

Any pointers?

Possible duplicate of [How do I tell if a regular file does not exist in Bash?](https://stackoverflow.com/questions/638975/how-do-i-tell-if-a-regular-file-does-not-exist-in-bash) — jww, Mar 31 '18 at 22:05

score 41 · Accepted Answer · answered Feb 05 '12 at 01:25

41

Change it to this:

{
if [ ! -f /scripts/alert ]; then
    echo "File not found!"
    exit 0
fi
}

A conditional isn't a loop, and there's no place you need to jump to. Execution simply continues after the conditional anyway.

(I also removed the needless &&. Not that it should happen, but just in case the echo fails there's no reason not to exit.)

answered Feb 05 '12 at 01:25

Kerrek SB

Thanks makes more sense after your explanation :) – user1190083 Feb 08 '12 at 12:52
1

+1 for not continuing and for continuing to fail on failure to fail. – Mike Samuel Feb 27 '14 at 22:22
1

I would add >&2 and exit with a non zero value – David Barda Jun 16 '18 at 18:46

score 2 · Answer 2 · edited May 28 '15 at 20:32

2

Your problem is with the continue line which is normally used to skip to the next iteration of a for or while loop.

Therefore just removing the else part of your script should allow it to work.

edited May 28 '15 at 20:32

answered Feb 05 '12 at 01:26

Pluckerpluck

score 1 · Answer 3 · answered Feb 05 '12 at 01:26

1

Yes. Drop the else continue. It's entirely unneeded.

answered Feb 05 '12 at 01:26

Kevin

3 Answers3