Garbage in char array

Question

i have to compare two char array if they are equal of not. my first array is perfect but second one is printing garbage. i know why is it printing garbage, because of not finding the \0, which is at the end of the array and it goes on printing the whole array.

but i dont know how to deal with the garbage when i am comparing both of the arrays

class Credentials
{
    string name;
    string userName;
    string phoneNumber;
    char password[12];
    string email;
public:
    Credentials();
    Credentials(string, string);
    friend istream& operator >> (istream& in, Credentials&);
    bool operator == (Credentials&);
    ~Credentials();
};


istream& operator>>(istream& in, Credentials& object)
{
    start:
    //system("cls");
    ConsoleControl* C = new ConsoleControl;
    int* initialX = new int(35);
    int* initialY = new int(4);
    int* border = new int(50);
    char confirmPassword[12];

    C->setCursorPosition(*initialX, *initialY);
    C->makeBorder(*border);
    cout << "Name: ";
    getline(cin, object.name);

    C->setCursorPosition(*initialX, *initialY * 2);
    C->makeBorder(*border);
    cout << "User Name: ";
    cin >> object.userName;

    C->setCursorPosition(*initialX, *initialY * 3);
    C->makeBorder(*border);
    cout << "Phone Number: ";
    cin >> object.phoneNumber;

    C->setCursorPosition(*initialX, *initialY * 4);
    C->makeBorder(*border);
    cout << "Email: ";
    cin >> object.email;

    C->setCursorPosition(*initialX, *initialY * 5);
    C->makeBorder(*border);
    cout << "Password: ";
    int i;
    for (i = 0; i < 12; i++) 
    {
        char ch = _getch();
        if(ch == 13) break;
        object.password[i] = ch;
        _putch('*');
    }   
    cout << object.password; //it doesnt show garbage

    C->setCursorPosition(*initialX, *initialY * 6);
    C->makeBorder(*border);
    cout << "ReEnter Password: ";
    for (i = 0; i < 12; i++)
    {
        char ch = _getch();
        if (ch == 13) {
            break;
            char end = '\0';
            confirmPassword[i] = end;
        }
        confirmPassword[i] = ch;
        _putch('*');
    }
    cout << confirmPassword; //here it shows garbage value


    if (strcmp(object.password, confirmPassword))
    {
        char color[] = "color 4F";
        C->setColor(color);
        system("cls");
        C->setCursorPosition(45, 15);
        cout << "\aPasswords do not match";

    }
    else
    {
        system("cls");
        cout << "MATCHED";
    }


    
    return in;
}

object is an object of a class

@HuzaifaMalik then read again, and [edit] your question accordingly! — πάντα ῥεῖ, Jun 04 '22 at 16:05
So where's the declaration of `confirmPassword` and `object` ? — Richard Critten, Jun 04 '22 at 16:05
there is no problem in the declaration etc according to me but i will do it if you are saying — Huzaifa Malik, Jun 04 '22 at 16:06
Does the compiler warn you about the unreachable code? Have you enabled compiler warnings? — 273K, Jun 04 '22 at 16:15
yes i have enabled the warnings. i am using vs 2022, but there is no warning ragarding the char array — Huzaifa Malik, Jun 04 '22 at 16:26
`break; char end ...` this is unreachable code! After the `break` we immediately exit the loop, without executing the next lines adding the string terminator. Put the `break` after that. Or put the code adding the terminator after the loop. — chi, Jun 04 '22 at 16:27
`ConsoleControl* C = new ConsoleControl; int* initialX = new int(35); int* initialY = new int(4); int* border = new int(50);` -- Why are you doing any of this (using `new`)? This is a pointless use of pointers. No extra pointers are required to set the current object `this`. — PaulMcKenzie, Jun 04 '22 at 16:35
i was using these so that i can delete them at the end of the function for the program to be memory efficient. — Huzaifa Malik, Jun 04 '22 at 16:40
@HuzaifaMalik -- *to be memory efficient.* -- No, it does nothing except unnecessarily call the allocator for no reason, leaves you open for memory leaks, obfuscates the function, and slows your code down. — PaulMcKenzie, Jun 04 '22 at 16:41
oh, ok. i'll remove these pointers then use simple data types — Huzaifa Malik, Jun 04 '22 at 16:42

score -2 · Answer 1 · answered Jun 04 '22 at 16:06

-2

You can't just compare 2 arrays by an equal operator How to Compare 2 Character Arrays

If you really want to compare them in such way then use std::string for storage.

answered Jun 04 '22 at 16:06

konradk

45
1
3

How do you know the type of `object.password` is the array from that tiny code? – 273K Jun 04 '22 at 16:08
i have tried strcmp, but same result – Huzaifa Malik Jun 04 '22 at 16:09
class Credentials { string name; string userName; string phoneNumber; char password[12]; string email; public: Credentials(); Credentials(string, string); friend istream& operator >> (istream& in, Credentials&); bool operator == (Credentials&); ~Credentials(); }; – Huzaifa Malik Jun 04 '22 at 16:10
I've read the description. – konradk Jun 04 '22 at 16:11
Still does not answer the question about the garbage in char arrays. – 273K Jun 04 '22 at 16:38

Garbage in char array

1 Answers1