0

I read inline suggestion from https://google.github.io/styleguide/cppguide.html#Inline_Functions, said that Define functions inline only when they are small, say, 10 lines or fewer.

I am curious that does the change below(get a new line between two paraments in one sentence for clarity) influence inline? (I assume not, but not sure), thanks.

inline VkRenderPassBeginInfo createRenderPassBeginInfo(size_t i, std::array<VkClearValue, 2>* clearValues) {
    VkRenderPassBeginInfo renderPassInfo{};
    renderPassInfo.sType = VK_STRUCTURE_TYPE_RENDER_PASS_BEGIN_INFO;
    renderPassInfo.renderPass = mRenderPass;
    renderPassInfo.framebuffer = mSwapChainFramebuffers[i];
    renderPassInfo.renderArea.offset = {0, 0};
    renderPassInfo.renderArea.extent = mSwapChainExtent;
    renderPassInfo.clearValueCount = static_cast<uint32_t>(clearValues->size());
    renderPassInfo.pClearValues = clearValues->data();
    return renderPassInfo;
}

to

inline VkRenderPassBeginInfo createRenderPassBeginInfo(size_t i, 
                                                                                                std::array<VkClearValue, 2>* clearValues) {
    VkRenderPassBeginInfo renderPassInfo{};
    renderPassInfo.sType = VK_STRUCTURE_TYPE_RENDER_PASS_BEGIN_INFO;
    renderPassInfo.renderPass = mRenderPass;
    renderPassInfo.framebuffer = mSwapChainFramebuffers[i];
    renderPassInfo.renderArea.offset = {0, 0};
    renderPassInfo.renderArea.extent = mSwapChainExtent;
    renderPassInfo.clearValueCount 
              = static_cast<uint32_t>(clearValues->size());
    renderPassInfo.pClearValues = clearValues->data();
    return renderPassInfo;
}
dreakzts
  • 11
  • 3

0 Answers0