Replacing character in href zip_ to zip

Question

This jQuery code works half the time depending on browser. Is there a better way to write this replace. Change and href link with .zip_ to .zip

jQuery("a[href*='.zip_']").each(function() {
  jQuery(this).attr("href", jQuery(this).attr("href").replace(/\.zip_/g, ".zip"));
});

There's nothing inherently wrong with the code. Can you show an example case of it not working. Also note that the code could be reduced to just: `$("a[href*='.zip_']").attr('href', (i, h) => h.replace(/\.zip_/g, ".zip")));` — Rory McCrossan, Oct 27 '21 at 17:29

Rawley Fowler · Answer 1 · 2021-10-27T17:51:48.230

0

Your solution is fine but it could be broken up a little bit to make it easier to read. I would personally use:

jQuery("a[href*='.zip_']").each(function() {
  const attr = jQuery(this).attr("href").split(".");
  attr[attr.length - 1] = ".zip";
  jQuery(this).attr("href", attr.join(''));
});

This should work as Mozilla suggests split works in all browsers. Also make sure you are using this in your $(document).ready(). This also makes the assumption .zip is at the end of the href.

edited Oct 27 '21 at 17:51

answered Oct 27 '21 at 17:16

Rawley Fowler

349
3
12

I am receiving `filename.zip_.zip` instead of `filename.zip` – acctman Oct 27 '21 at 17:34
@acctman Can you specify what the hrefs look like before you parse them? Is .zip at the end? – Rawley Fowler Oct 27 '21 at 17:47

Replacing character in href zip_ to zip

1 Answers1