getAttribute is not a function - can't iterate loop for every element

Question

I know there is many similar questions but I don't know why it doesn't work to me

I have collection

cars = document.gelementsByClassName('car');
for (i in cars){
               let attr = cars[i].getAttribute('segment');
               }

And its going down with messege "getAttribute is not a function" and loop is not go to end. I tried use try-catch but it doesn't word loop still not go to end Even it is really error i would like to ignore this error and go to end.

I'm more surprised you don't get an error earlier, since `gelementsByClassName` isn't a function. Typo in your example code? — Kelvin Schoofs, Jul 23 '21 at 16:42
Does any code in the page tamper with prototypes? Plus, try putting a `console.log(i)` before the erroneous line, so you'll see what property it has problem with (and what's its value). — FZs, Jul 23 '21 at 17:04

score 0 · Accepted Answer · answered Jul 23 '21 at 16:46

0

You should be using document.getElementsByClassName('car') instead.

Also, to iterate through the NodeList using a for..in loop, you have to use spread syntax (...).

var cars = [...document.getElementsByClassName('car')];
for (i in cars) {
  let attr = cars[i].getAttribute('segment');
  console.log(attr);
}

<div class="car" segment="1"></div>
<div class="car" segment="2"></div>
<div class="car" segment="3"></div>

answered Jul 23 '21 at 16:46

Spectric

27,594
6
14
39

Um, actually, it's [not too good to use `for..in` even with spead here](https://stackoverflow.com/questions/500504/why-is-using-for-in-for-array-iteration-a-bad-idea); instead of the spread, you could just do `for..of` (it also works on Iterables) – FZs Jul 23 '21 at 17:01
Console log Show null – Agnes Jul 23 '21 at 18:17
@Agnes have you tried running the snippet? It works. – Spectric Jul 23 '21 at 20:11
Thanks, I thing the brackets [...] solve my problem. Thanks Spectric – Agnes Jul 24 '21 at 10:30
@Agnes no problem :) – Spectric Jul 24 '21 at 14:04

getAttribute is not a function - can't iterate loop for every element

1 Answers1