Getting sed: -e expression #1, char 41: unterminated `s' command

Question

I am running shell script to update the pom version but getting the below error.

sed: -e expression #1, char 41: unterminated `s' command

Shell Script

#!/bin/sh            
tag=$(grep '<version>' $2 | sed 's/<version>[^-]*-\(.*\)<\/version>/\1/')
sed -i "s/<version>.*<\/version>/<version>$1-${tag}<\/version>/" $2

Pom.xml

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
        <modelVersion>4.0.0</modelVersion>
        <groupId>org.acumos.onboarding</groupId>
        <artifactId>onboarding-app</artifactId>
        <version>4.0.0-</version>
        <name>Onboarding app for public use</name>
        <parent>
                <groupId>org.springframework.boot</groupId>
                <artifactId>spring-boot-starter-parent</artifactId>
                <version>4.0.0-</version>
                <relativePath />
        </parent>

Here instead of 4.0.0, I am expecting 4.0.2

I am running the script as ./script.sh <version_name> pom.xml

New pom.xml

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
        <modelVersion>4.0.0</modelVersion>
        <groupId>org.acumos.onboarding</groupId>
        <artifactId>onboarding-app-open</artifactId>
        <version>4.0.0-</version>
        <name>Onboarding app for public use</name>
        <parent>
                <groupId>org.springframework.boot</groupId>
                <artifactId>spring-boot-starter-parent</artifactId>
                <version>4.0.0-</version>
                <relativePath />
        </parent>

</project>

My output

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
        <modelVersion>4.0.0</modelVersion>
        <groupId>org.acumos.onboarding</groupId>
        <artifactId>onboarding-app-open</artifactId>
        <version>4.0.0-</version>
        <name>Onboarding app for public use</name>
        <parent>
                <groupId>org.springframework.boot</groupId>
                <artifactId>spring-boot-starter-parent</artifactId>
                <version>4.0.0-</version>
                <relativePath />
    </parent>

</project>

Script run method ./script.sh 3.0 pom.xml

Answer 1

With awk could you please try following, written and tested with shown samples only.

awk '
match($0,/.*<version>([0-9]+\.){1,}[0-9]+-<\/version>/) && ++count==1{
  val=substr($0,RSTART,RLENGTH)
  sub(/\.0/,".2",val)
  print val
  next
}
1
'  Input_file

Explanation: Adding detailed explanation for above.

awk '                            ##Starting awk program from here.
match($0,/.*<version>([0-9]+\.){1,}[0-9]+-<\/version>/) && ++count==1{  ##Using match function to match regex of <version> digits dot(1 or more occurrences) followed by digits - </version> and making sure its happening only 1 time.
  val=substr($0,RSTART,RLENGTH)  ##Creating val which is sub string of matched regex above.
  sub(/\.0/,".2",val)            ##Substituting .0 with .2 in val to get exact version asked by OP.
  print val                      ##Printing val here.
  next                           ##next will skip all statements from here.
}
1                                ##1 will print edited/non-edited lines here.
' Input_file                     ##Mentioning Input_file name here.

NOTE: Above will print the results, once you are Happy with results shown on terminal then append > temp && mv temp Input_file to above code to save output into Input_file itself.

---

---

To run this in bash script try following.

#!/bin/bash

awk -v ver="$1" '
match($0,/.*<version>([0-9]+\.){1,}[0-9]+-<\/version>/) && ++count==1{
  val=substr($0,RSTART,RLENGTH)
  sub(/\.0/,".2",val)
  print val
  next
}
1
' "$2"

Now run it as follows(don't forget to give execute permissions to script).

./script.bash "3.0" "your_file"