Static array variable of another class' objects does not allow calling methods of the second class

Question

I am can't figure out why this doesn't work:

class Test
{
    public static $arData=array();

    public static function addMember(Person $member)
    {
        self::$arData[]=$member;
    }
    public static function showAll()
    {
        for($i=0;$i<count(self::$arData);$i++)
        {
            self::$arData[i]->show();
        }
    }
}

What I get is this: Fatal error: Call to a member function show() on a non-object. The show() method does exist and it basically prints out name and location of a person.
In in the constructor, instead of adding $member to $arData I do $member->show() it works.

So... what's up?

read the first answer of this question just to start http://stackoverflow.com/questions/4891301/top-bad-practices-in-php — dynamic, Jul 06 '11 at 16:00
what do you get if you do `print_r(self::$arData)` in show all rather going through the loop? — ianbarker, Jul 06 '11 at 16:00
Ian: I get an array of Person Objects with [name:private] and [location:private] for each element added. — Francisc, Jul 06 '11 at 16:04

score 3 · Accepted Answer · answered Jul 06 '11 at 16:02

3

Try

self::$arData[$i]->show();

answered Jul 06 '11 at 16:02

christopher_b

938
5
13

score 2 · Answer 2 · answered Jul 06 '11 at 16:01

2

How about this:

foreach (self::$arData as $person) {
    $person->show();
}

answered Jul 06 '11 at 16:01

Alex Howansky

47,154
8
74
95

That would have bypassed the missing `$` sign in front of the `i`. Thanks. – Francisc Jul 06 '11 at 16:06
1

It also avoids counting the array in every iteration. – Alex Howansky Jul 06 '11 at 16:08

score 1 · Answer 3 · answered Jul 06 '11 at 16:02

1

The error is in the for-loop:

...
public static function showAll()
{
    for($i=0;$i<count(self::$arData);$i++)
    {
        self::$arData[$i]->show();
    }
}
...

It must be $i and not only i in the array-access-operator when calling the show()-method.

answered Jul 06 '11 at 16:02

Stefan Gehrig

80,936
24
154
184

Unbelievable... thank you Stefan. – Francisc Jul 06 '11 at 16:05

Static array variable of another class' objects does not allow calling methods of the second class

3 Answers3