0

I was solving a Stack problem in which I needed to make a Simple Text Editor, But in some test cases with Queries input > 10^6 my code is showing an error of Time limit exceeded

Here is the Problem Statement In this challenge, you must implement a simple text editor. Initially, your editor contains an empty string, S. You must perform Q operations of the following types:

  • append - Append string W to the end of S.
  • delete - Delete the last k characters of S.
  • print - Print the kth character of S.
  • undo - Undo the last (not previously undone) operation of type 1 or 1, reverting S to the state it was in prior to that operation.

Here is my code:-

    #include <cmath>
#include <cstdio>
#include <vector>
#include<stack>
#include <iostream>
#include<string>
#include<sstream>
#include <algorithm>
using namespace std;

void TextEditor(vector<pair<int, string>>& v) {
    auto it = v.begin();
    int x;
    stack<string>s;
    string inputString="";
    s.push(inputString);

    while (it != v.end()) {
        
        if (it->first == 1) {
            string topString =s.top();
            inputString = it->second;
            s.push(topString.append(inputString));
        }
        else if(it->first==2){
            stringstream ss(it->second);
            ss >> x;
            string del;
            del = s.top();

            if (del != "") {
                int idx = del.length() - x;
                s.push(del.erase(idx));
            }
        }
        else if (it->first == 3) {
            stringstream ss(it->second);
            ss >> x;
            string print;
            print = s.top();
            cout << print[x-1] <<endl;
        }
        else if (it->first == 4) {
            s.pop();
        }
        
        
        it++;
    }
}
int main() {
    int Q,t,ti;
    string s;
    cin >> Q;
    vector<pair<int, string>>v;
    for (int i = 0; i < Q; i++) {
        cin >> t;
        if (t == 4) {
            v.push_back(make_pair(t, "0"));
        }
        else {
            cin >> s;
            v.push_back(make_pair(t, s));
        }
    }

    TextEditor(v);
    return 0;
}

in the code used stl libraries to solve this problem but it is showing time limit exceeds the error. Can anybody help me optimize the code?

user58697
  • 7,340
  • 1
  • 12
  • 27
Anmol Ahuja
  • 31
  • 1
  • What do you hope to learn from these contest/challenge/competitive coding/hacking sites? If it's to learn C++, you won't learn anything there. Like in this case, the correct solution is based on a mathematical or a programming trick. If you don't know what the trick is and attempt to code a brute-force approach, the program either runs slow, or fails to handle an obscure edge case. If you're trying to learn C++, you won't learn anything from meaningless online contest sites [but only from a good C++ textbook](https://stackoverflow.com/questions/388242/the-definitive-c-book-guide-and-list). – Sam Varshavchik Jan 09 '21 at 18:35
  • @SamVarshavchik actually, I am trying to learn data structure and algorithms by solving problems on hackerrank. Is this not a good platform to learn about dsa? – Anmol Ahuja Jan 09 '21 at 19:23
  • No,it's not. hackerrank, geeksforgeeks, and countless other similar sites are just a meaningless list of pointless puzzles, without any kind of a rigorous, organized, tutorials or explanations of core fundamental principles of C++, the most complicated general purpose programming language in use today. C++ cannot be effectively learned from some website or a youtube video, but only from an edited, and vetted, quality textbook. – Sam Varshavchik Jan 09 '21 at 19:28

0 Answers0