How do I remove all instances of an element that appear in an array?

Question

The code I have right now, removes most of the instances, however it does not remove all of them. What am I doing wrong?

let nums = [1, 90, 90, 1123, 90, 4534, 90, 90, 90, 90, 90];

function removeAll(array, item) {
  for (var i = 0; i < array.length; i++) {
    if (array[i] === item) {
      array.splice(array.indexOf(item), 1);
    }
  }
  return array;
}
    
console.log(removeAll(nums, 90));

`array.splice` will change the array use `array.filter` instead — Sivakumar Tadisetti, Jul 15 '20 at 06:35
You are removing elements from the array while looping it. That is rarely a good idea. — str, Jul 15 '20 at 06:39

score 0 · Answer 1 · answered Jul 15 '20 at 06:39

0

let nums = [1, 90, 90, 1123, 90, 4534, 90, 90, 90, 90, 90];

function removeAll(array, item) {
  return array.filter(function(value) {
    return value !== item;
  });
}

console.log(removeAll(nums, 90));

answered Jul 15 '20 at 06:39

Sivakumar Tadisetti

4,503
6
32
54

How do I remove all instances of an element that appear in an array?

1 Answers1