How correctly wait of ends of thread array on c#?

Question

I need to use clear thread class (not Task and without async/await). How I can correctly wait of the ends of all task in list?

I want correctly method WaitAll()

For example:

public class TaskManager
{
    private readonly List<Thread> _threads = new List<Thread>();

    public void AddTask([NotNull] Action<int> action, int i)
    {
        var thread = new Thread(() =>
        {
            action(i);
        });
        _threads.Add(thread);
        thread.Start();
    }

    public void WaitAll()
    {
        while (_threads.Any(x => x.ThreadState != ThreadState.Stopped))
        {
        }
    }
}

Why would you need _"clear thread class (not Task ...)"_ ? That immediately makes it look like an X/Y question. — Henk Holterman, Dec 08 '19 at 08:47
`public void WaitAll() { foreach (var t in _threads) t.Join(); }` — Sani Singh Huttunen, Dec 08 '19 at 08:50
Does this answer your question? [Create multiple threads and wait all of them to complete](https://stackoverflow.com/questions/4190949/create-multiple-threads-and-wait-all-of-them-to-complete) — Sani Singh Huttunen, Dec 08 '19 at 08:51
In 3.5 you at least have the ThreadPool, but that would make your management very different. Maybe even unnecessary. — Henk Holterman, Dec 08 '19 at 09:02
Can't you use this sample code? https://docs.microsoft.com/en-us/dotnet/api/system.threading.thread?view=netframework-4.8 and this for .net 3.5 https://docs.microsoft.com/en-us/dotnet/api/system.threading.thread?view=netframework-3.5 (does not make any difference though) — brainless coder, Dec 08 '19 at 09:04
Maybe a duplicate, but a clear question und no reason to close for unclearity. — Holger, Dec 08 '19 at 09:07

score 1 · Accepted Answer · answered Dec 08 '19 at 08:51

I question the need for 'bare threads' but when you're sure about that, then waiting in a while-loop is wasting CPU time. Threads only have the Join() method available for this:

public void WaitAll()
{
   foreach(var thread in _threads)    
     thread.Join();
}

How correctly wait of ends of thread array on c#?

1 Answers1