77

The book "Essential JNI: Java Native Interface" by Rob Gordon contains the following code example to convert a jstring to a C string:

const char* utf_string;
jboolean isCopy;
utf_string = env->GetStringUTFChars(str, &isCopy);
/* ... use string ... */
if (isCopy == JNI_TRUE) {
    env->ReleaseStringUTFChars(str, utf_string);
}

Note that it only calls ReleaseStringUTFChars if isCopy is true.

But the book Java Native Interface: Programmer's Guide and Specification (alternate link: http://192.9.162.55/docs/books/jni/html/objtypes.html#5161) says:

The ReleaseString-Chars call is necessary whether GetStringChars has set *isCopy to JNI_TRUE or JNI_FALSE. ReleaseStringChars either frees the copy or unpins the instance, depending upon whether GetStringChars has returned a copy or not.

I am correct in assuming this is a bug in Gordon's book?

Flavio
  • 11,595
  • 3
  • 31
  • 36
Edward Loper
  • 14,489
  • 7
  • 42
  • 50

1 Answers1

64

Yes, your assumption is correct (you should always call ReleaseStringUTFChars).

Brett Kail
  • 33,148
  • 2
  • 86
  • 88
  • What happen does if it will not be called ? – Bulma Dec 12 '17 at 03:42
  • 2
    Memory will be leaked (the JVM will believe that you need the memory indefinitely). – Brett Kail Dec 12 '17 at 13:21
  • 2
    Sure ! But why we don't have free allocated memory function for another data types such as : int, double . It should be RealseInt(arg,arg), ReleaseDouble(arg,arg)...or something like that ? – Bulma Dec 13 '17 at 02:00
  • 4
    Int and double aren't variable-length like strings, so the data can be trivially copied to the caller. (It's probably best to create a new question rather than continuing a conversation on a 6-year-old answer.) – Brett Kail Dec 13 '17 at 03:02