When i run the code it always give a 0 output for division?

Question

I am solving the hacker rank problem plus minus and encountered the problem where the division gives 0.0000

int main()
{
    int array_size;
    printf("Enter the size of array: \n");
    scanf("%d",&array_size);

    int array [array_size];
    for(int i=0;i<array_size;i++)
    {
        scanf("%d",&array[i]);
    }

    int positive=0;
    int negative=0;
    int zero=0;
    for(int i =0; i<array_size;i++)
    {
        if(array[i]<0)
        {
            negative++;
        }
        if(array[i]>0)
        {
            positive++;
        }
        if(array[i]=0)
        {
            zero++;
        }
    }
    float x = positive / array_size;
    float y = negative / array_size;
    float z = zero / array_size;
    printf("%lf \n",x);
    printf("%lf \n",y);
    printf("%lf \n",z);

    return 1;

}

Actual Result:- 0.00000000 0.00000000 0.00000000

Expected Result:- The actual divisions...

`int array_size;`, `int positive` ==> `positive / array_size` is integer division. Try `(double)positive / array_size` — pmg, Jun 13 '19 at 12:32
`if( array[i]=0)` should read `if( array[i]==0)`. Note the `==`. A single `=` is an assignment. — Øystein Schønning-Johansen, Jun 13 '19 at 12:33
Furthermore, I think it's more efficient to use if ... else if ... — Robert Kock, Jun 13 '19 at 12:35
If I were you, I would print out the array size and the contents of the array before trying to count the number of positive and negative numbers. You want to make sure you have read in the data correctly before trying to process it. — Stuart, Jun 13 '19 at 13:02

alinsoar · Answer 1 · 2019-06-13T13:30:35.590

0

You need to cast to float. Otherwise the arithmetic conversions will convert only the integer result to float.

float x = positive / array_size

You want

float x = (float) positive / array_size

The full algorithm of conversions is presented in ISO 9899, chapter 6.3.1.8 Usual arithmetic conversions

edited Jun 13 '19 at 13:30

answered Jun 13 '19 at 13:18

alinsoar

14,813
4
53
68

Thank you sir, it worked! But can you please elaborate the explanation? I am not able to understand what you meant by "Otherwise the arithmetic conversions will convert only the integer result to float.". – Janit Lodha Jun 13 '19 at 13:26
@JanitLodha completed – alinsoar Jun 13 '19 at 13:30

When i run the code it always give a 0 output for division?

1 Answers1