My PathVariables does not work

Question

Hello I would like to write a Get method with Spring Rest but my code is not working code is below;

@RequestMapping(value = "userRight/hasRightForOperation", method = RequestMethod.GET, consumes = MediaType.APPLICATION_JSON_VALUE, produces = MediaType.APPLICATION_JSON_VALUE)
    public ResponseEntity<?> hasRightForOperation(@PathVariable(value = "loginName") String loginName,
            @PathVariable(value = "vendorId") String vendorId,
            @PathVariable(value = "accessRightCode") String accessRightCode) {
        return new ResponseEntity<>(hasRightForOperation(loginName, vendorId, accessRightCode), HttpStatus.OK);

Thank you in advance

I think you want to use a parameter. Just remove the `@PathVariable(...)` annotation. Else, please show the URL you are sending a GET request to. — Impulse The Fox, Aug 29 '18 at 07:05

score 1 · Accepted Answer · answered Aug 29 '18 at 07:10

@RequestMapping(value = "userRight/hasRightForOperation", method = RequestMethod.GET, consumes = MediaType.APPLICATION_JSON_VALUE, produces = MediaType.APPLICATION_JSON_VALUE)
public ResponseEntity<?> hasRightForOperation(@PathVariable(value = "loginName") String loginName,
        @PathVariable(value = "vendorId") String vendorId,
        @PathVariable(value = "accessRightCode") String accessRightCode) {
    return new ResponseEntity<>(hasRightForOperation(loginName, vendorId, accessRightCode), HttpStatus.OK);

You are using @PathVariable but there is no param to your url mapping. You can fix like

@RequestMapping(value = "userRight/hasRightForOperation/{loginName}/{vendorId}/{accessRightCode}", method = RequestMethod.GET, consumes = MediaType.APPLICATION_JSON_VALUE, produces = MediaType.APPLICATION_JSON_VALUE)
public ResponseEntity<?> hasRightForOperation(@PathVariable(value = "loginName") String loginName,
        @PathVariable(value = "vendorId") String vendorId,
        @PathVariable(value = "accessRightCode") String accessRightCode) {
    return new ResponseEntity<>(hasRightForOperation(loginName, vendorId, accessRightCode), HttpStatus.OK);

You can change order of url mapping params. So if you dont wants in url mapping, you can get params with @RequestParam tags.

@GetMapping(value = "userRight/hasRightForOperation", consumes = MediaType.APPLICATION_JSON_VALUE, produces = MediaType.APPLICATION_JSON_VALUE)
public ResponseEntity<?> hasRightForOperation(@RequestParam("loginName") String loginName,
                                              @RequestParam("vendorId") String vendorId,
                                              @RequestParam("accessRightCode") String accessRightCode) {
    return new ResponseEntity<>(hasRightForOperation(loginName, vendorId, accessRightCode), HttpStatus.OK);
}

Alien · Answer 2 · 2018-08-29T07:12:45.700

0

You have to receive path variables in URL so for doing that add all params like below.

Change

@RequestMapping(value = "userRight/hasRightForOperation", method = RequestMethod.GET, consumes = MediaType.APPLICATION_JSON_VALUE, produces = MediaType.APPLICATION_JSON_VALUE)

to

@RequestMapping(value = "userRight/hasRightForOperation/{loginName}/{vendorId}/{accessRightCode}", method = RequestMethod.GET, consumes = MediaType.APPLICATION_JSON_VALUE, produces = MediaType.APPLICATION_JSON_VALUE)

I will recommend you to use @RequestParam for this.

See this : @RequestParam vs @PathVariable

edited Aug 29 '18 at 07:12

answered Aug 29 '18 at 07:04

Alien

13,439
5
35
53

Thank you but what about vendorId and AccessRightCode do ı need to change them too according to that code – phantasma Aug 29 '18 at 07:07
yes updated the answer accordingly...make sure while hitting the controller the parameters should be in same sequence. – Alien Aug 29 '18 at 07:07
please accept and upvote the answer if it helped you. – Alien Aug 29 '18 at 07:14

My PathVariables does not work

2 Answers2