Expected 2 arguments, but got 1.

Question

I have function in ts

 export function minutesToHoursAndMinutes(m, zeroPadded) {
    if (zeroPadded == null) { zeroPadded = false; }
    let hours:any = Math.floor(m / 60);
    if (zeroPadded && (`${hours}`.length === 1)) { hours = `0${hours}`; }
    let minutes:any = m % 60;
    if (zeroPadded && (`${minutes}`.length === 1)) { minutes = `0${minutes}`; }
    if ((hours === 24) && (minutes === '00')) {
      hours = 23;
      minutes = 59;
    }
    return [hours, minutes];
  };

And try to use it like this

if (("#t-time-range").length > 0) {
$("#t-time-range").slider({
  range: "min",
  value: filter_max.max_traveltime,
  min: filter_max.min_traveltime,
  max: filter_max.max_traveltime+15,
  step: 15,
  slide(event, ui) {
    const hms = FilterFunctions.minutesToHoursAndMinutes(ui.value );
    $("#t-time").val(`Max ${hms[0]}t ${hms[1]}m`);
    return $('#filter_travel_time').val(ui.value);
  }
});
const hms = FilterFunctions.minutesToHoursAndMinutes($("#t-time-range").slider("value"));
$("#t-time").val(`Max ${hms[0]}t ${hms[1]}m`);
$('#filter_travel_time').val($("#t-time-range").slider("value"));

}

But I have error about argues

Like this

Expected 2 arguments, but got 1.

How I can make 2 argument optional?

`FilterFunctions.minutesToHoursAndMinutes($("#t-time-range").slider("value"))` you are only giving these two calls one argument ... — Taplar, Mar 28 '18 at 14:18
You can just pass in `null` as the second parameter or change `zeroPadded` to `zeroPadded?` in the type signature — itsmewiththeface, Mar 28 '18 at 14:19
You could also take the zeroPadded off of the method definition and the cases where you want to use it just reference `arguments[1]` — Taplar, Mar 28 '18 at 14:20
Did you do any research? https://www.google.com/search?q=typescript+make+argument+optional — SLaks, Mar 28 '18 at 14:20
Do something like this `export function minutesToHoursAndMinutes(m, zeroPadded = null )` — Rajendran Nadar, Mar 28 '18 at 14:20

score 0 · Answer 1 · answered Mar 28 '18 at 14:19

0

try changing the last property of your slider object to

slide: function(event, ui) {
    const hms = FilterFunctions.minutesToHoursAndMinutes(ui.value );
    $("#t-time").val(`Max ${hms[0]}t ${hms[1]}m`);
    return $('#filter_travel_time').val(ui.value);
}

answered Mar 28 '18 at 14:19

Carlos Wagner

19
3

`minutesToHoursAndMinutes` still expects two arguments – Andreas Mar 28 '18 at 14:22
Try passing false as an argument during the 2 invocations and removing the first line if (zeroPadded == null) { zeroPadded = false; } from the minutesToHoursAndMinutes function. – Carlos Wagner Mar 28 '18 at 14:30
So your solution (hidden in the comments) to the problem is: "Pass two arguments" – Andreas Mar 28 '18 at 14:34
Considering that the rest of the snippet is already pure spaghetti... – Carlos Wagner Mar 28 '18 at 14:38

score 0 · Answer 2 · answered Mar 28 '18 at 14:22

0

Perhaps setting a default value such as

export function minutesToHoursAndMinutes(m, zeroPadded=null).

This way the value is already set, and if you do not pass an argument, it will default to the null value.

answered Mar 28 '18 at 14:22

Colin Roberts

33
7

score 0 · Answer 3 · answered Mar 28 '18 at 14:27

0

? makes argument optional. Reference.
export function minutesToHoursAndMinutes(m, zeroPadded?) {

answered Mar 28 '18 at 14:27

3rdthemagical

5,073
16
34

Expected 2 arguments, but got 1.

3 Answers3