Check if object is a 'direct instance' of a class

Question

I have two classes:

class Bar extends Foo { // Foo isn't relevant
  constructor(value) {
    if (!(value instanceof Foo)) throw "InvalidArgumentException: (...)";
    super();
    this.value = value;
  }
}

class Baz extends Bar {
  constructor(value) {
    super(value);
  }
}

The Bar constructor checks if value is an instance of Foo, it throws an error if it isn't. At least, that's what I wanted it to do. If you pass a Bar or a Baz as value, the if-statement returns true as well. The goal is to only let Foos through.
I found this answer already but that didn't really answer my question.

[This answer](https://stackoverflow.com/a/8715426/9524541) from the other quesiton you linked seems to work. Only a Foo object created with `new Foo()` would return "Foo" when calling `foo.constructor.name` — SystemGlitch, Mar 21 '18 at 21:59
What do you think you need this for? It seems like you are misusing inheritance, as your goal is to break the [Liskov Substitution Principle](https://en.wikipedia.org/wiki/Liskov_substitution_principle). Don't do that. Every `Bar` and `Baz` instance should be valid where you want to have a `Foo` instance. — Bergi, Mar 22 '18 at 02:30

Mohammad Dehghan · Accepted Answer · 2018-03-22T07:14:20.673

9

Check the constructor:

if (!value || value.constructor !== Foo)
  throw 'InvalidArgumentException: (...)';

or the prototype of the object (this is more similar to what instanceof does):

if (!value || Object.getPrototypeOf(value) !== Foo.prototype)
  throw 'InvalidArgumentException: (...)';

edited Mar 22 '18 at 07:14

answered Mar 21 '18 at 21:59

Mohammad Dehghan

17,154
3
54
67

1

This does not answer the core question. It does not solve the inheritance problem. – Joshua Manns Mar 21 '18 at 22:03

CRice · Answer 2 · 2018-03-21T22:17:24.627

You can use a comparison between Object.getPrototypeOf(yourObj) and Foo.prototype to see if yourObj is exactly an instance of Foo. And you can move up the chain by just continuing to call Object.getPrototypeOf for each level.

Example:

class Foo {}

class Bar extends Foo {}
class Baz extends Bar {}

const foo = new Foo();
const bar = new Bar();
const baz = new Baz();

// For this function:
// - level 0 is self
// - level 1 is parent
// - level 2 is grandparent
// and so on.
function getPrototypeAt(level, obj) {
    let proto = Object.getPrototypeOf(obj);
    while (level--) proto = Object.getPrototypeOf(proto);
    return proto;
}

console.log("bar is a foo:", bar instanceof Foo);
console.log("baz is a foo:", baz instanceof Foo);
console.log("foo is exactly a foo:", getPrototypeAt(0, foo) === Foo.prototype);
console.log("bar is exactly a foo:", getPrototypeAt(0, bar) === Foo.prototype);
console.log("bar is direct child of foo:", getPrototypeAt(1, bar) === Foo.prototype);
console.log("baz is direct child of foo:", getPrototypeAt(1, baz) === Foo.prototype);
console.log("baz is direct child of bar:", getPrototypeAt(1, baz) === Bar.prototype);
console.log("baz is grandchild of foo:", getPrototypeAt(2, baz) === Foo.prototype);

score 1 · Answer 3 · answered Mar 21 '18 at 22:10

1

You should test if value's internal [[Prototype]] is exactly Foo.prototype. You can get the internal [[Prototype]] with Object.getPrototypeOf :

if ( Object.getPrototypeOf( value ) !== Foo.prototype )
   throw "InvalidArgumentException: (...)";

answered Mar 21 '18 at 22:10

Paul

135,475
25
268
257

score 0 · Answer 4 · answered Mar 21 '18 at 21:55

0

If you know all of your classes you can use

if(!(value instanceof Foo && !(value instanceof Bar) && !(value instanceof Baz)))

answered Mar 21 '18 at 21:55

Sebastian Speitel

6,813
2
19
36

@Sacha please see my answer for a generic check against other classes – Joshua Manns Mar 21 '18 at 22:05

score 0 · Answer 5 · answered Jan 25 '19 at 08:11

0

I coined the function for checking relationships between DOM Classes and elements

const getCreator = instance => Object.getPrototypeOf(instance).constructor.name;
// usage
getCreator(document.documentElement) === "HTMLHtmlElement;

answered Jan 25 '19 at 08:11

daGo

2,140
21
21

score -2 · Answer 6 · answered Mar 21 '18 at 22:02

-2

The problem is that all of your classes you reference are descendants of Foo. Such that new Baz() instanceOf Bar && new Bar() instanceOf Foo === true. So when you ask is Bar instanceOf Foo, it will be true through inheritance.

Due to there being no Java getClass() equivalent in JS, you should use something like:

if (value.constructor.name !== Foo.name)

answered Mar 21 '18 at 22:02

Joshua Manns

465
3
6

What does `getClass()` in Java do that `value.constructor` doesn't in JS? – Bergi Mar 22 '18 at 02:32
3

You should never compare the names of classes. They might be mangled by minifiers, they might be optimised away, they might be overwritten or faked. Never rely on names. – Bergi Mar 22 '18 at 02:34

Check if object is a 'direct instance' of a class

6 Answers6

Linked

Related