Shortest way to modify some element in list when condition is matched C#

Question

Ex. I want to modify the element in list that "id" is matched. I do like this.

for(int i=0;i<list.Count;i++){
    if(list[i].id==id){
        list[i].data = newData;
        break;
    }
}

Is there any shorter way to do?

Backs · Answer 1 · 2017-12-25T07:01:20.543

0

var dictionary = list.ToDictionary(o => o.id);
//...
dictionary[id].data = newData;

edited Dec 25 '17 at 07:01

answered Dec 25 '17 at 06:34

Backs

What happens when Id are multiple, possible in a List but not in a dictionary, will fail for duplicate records – Mrinal Kamboj Dec 25 '17 at 07:57
@MrinalKamboj it's out of this question. I don't know type of id and other data. – Backs Dec 25 '17 at 08:00
@MrinalKamboj isn't id expected to be unique? – yolo sora Dec 25 '17 at 08:18
@yolosora not necessary, `List` can easily contain duplication, no way to avoid it – Mrinal Kamboj Dec 26 '17 at 06:16

score 0 · Answer 2 · answered Dec 25 '17 at 06:36

0

list = list.Select(x =>
{
      if(x.id == id)
      {
           x.data = newdata;
           break;
      }
      return x;
}

answered Dec 25 '17 at 06:36

Parth Savadiya

2 Answers2