How to make commands using str array in for loop by Python

Question

I want to do something like this

CMD_LIST = ['ls -l', 'echo Mama Mia', 'echo bla bla bla']
for i in range(len(CMD_LIST)):
    subprocess.call(CMD_LIST[1])

How can i do list of commands in for loop?

You're calling the 2nd command (index 1) over and over again. — CristiFati, Dec 08 '17 at 07:13
Edit your list this way and try: ["ls", "-l"] and subprocess.call(["ls", "-l"]) — yogesh10, Dec 08 '17 at 07:21

score 1 · Accepted Answer · answered Dec 08 '17 at 07:20

1

In subprocess you must provide your command as a list, with the first item being the command and each following item being the arguments.

In your case your code should look like:

CMD_LIST = [['ls', '-l'], ['echo', 'Mama Mia'], ['echo', 'bla bla bla']]
for cmd_arg in CMD_LIST:
    subprocess.call(cmd_arg)

answered Dec 08 '17 at 07:20

JamoBox

nice. Thanks. Its works – Artem Dec 08 '17 at 07:23
No problem, if it has solved your problem then please mark the answer as correct for completeness :) – JamoBox Dec 08 '17 at 07:26

score 0 · Answer 2 · answered Dec 08 '17 at 07:12

0

CMD_LIST = ['ls -l', 'echo Mama Mia', 'echo bla bla bla']

for i in range(len(CMD_LIST)):
    subprocess.call(CMD_LIST[i])

Did you mean this?

answered Dec 08 '17 at 07:12

User_Targaryen

score 0 · Answer 3 · answered Dec 08 '17 at 07:19

0

Python lets you loop directly over iterables like your command list

for cmd in CMD_LIST:
    subprocess.call(cmd)

This is much more readable and avoids errors in indexed looping.

answered Dec 08 '17 at 07:19

digitalsentinel

3 Answers3