Simple PHP comparison doesn't seem to work

Question

I am trying to check if the user is coming from outside the Netherlands or Belgium by using the following 'code':

$countrycode = 'NL'; 

if ($countrycode !== 'NL' || $countrycode !== 'BE') {
echo 'you are not from NL or BE';
} else {
echo 'you are from: ' . $countrycode;
}

I cannot figure out why it's echoing the first occurrence.

PS: I know I could just switch it by using === instead but I kinda wish to know why or what I am doing wrong.

Thanks

Because `$countrycode !== 'NL'` returns false and `$countrycode !== 'BE'` returns true, so `echo 'you are not from NL or BE';` is outputted — IsThisJavascript, Nov 06 '17 at 14:22
Possible duplicate of [php not equal to != and !==](https://stackoverflow.com/questions/3641819/php-not-equal-to-and) — Hassan Raza, Nov 06 '17 at 14:24
Better to use `if (!in_array($countrycode, ['NL','BE']))` instead - less error prone — Agnius Vasiliauskas, Nov 06 '17 at 14:38
@AgniusVasiliauskas cool! haven't seen that method before. will use that :) — Niels, Nov 06 '17 at 14:41

score 8 · Accepted Answer · answered Nov 06 '17 at 14:22

8

That should be AND not OR.

$countrycode = 'NL'; 

if ($countrycode !== 'NL' || $countrycode !== 'BE') { // Since 'NL' !== 'BE' this is true
    echo 'not from NL or BE';
} else {
    echo 'you are from: ' . $countrycode;
}

Your first line should be:

if ($countrycode !== 'NL' && $countrycode !== 'BE') {

answered Nov 06 '17 at 14:22

kchason

2,686
18
23

1

ah yea that makes sense. thanks for your quick response! (I can accept your answer in 3 minutes) – Niels Nov 06 '17 at 14:30

score 0 · Answer 2 · answered Nov 06 '17 at 14:24

0

Try the method strcmp(): http://php.net/manual/de/function.strcmp.php Just keep in mind that it returns an integer instead of boolean. Equality of strings is indicated with a 0 as return value. Also the comparison is case-sensitive.

answered Nov 06 '17 at 14:24

Alexander Tepe

148
1
1
10

Simple PHP comparison doesn't seem to work

2 Answers2