Node.js - promisify readline

Question

As the title states, I was wondering if it is possible to use promisify (https://nodejs.org/dist/latest-v8.x/docs/api/util.html#util_util_promisify_original) for readline in node.js? I was only able to do it like this:

let data = [];
const parse = () => {
    return new Promise((resolve, reject) => {

        const rl = readline.createInterface({
            input: fs.createReadStream(path)
        });

        rl.on('line', (line) => {
            data.push(line);
        });

        rl.on('close', () => {
            resolve(data);
        });
    });
};

You can only promisify error first callbacks, and with `promisify.custom` other types of callbacks that does not follow the pattern. For streams and event emitters you need to implement your own logic, it does share a common interface (with on `close`, on `finish` ) but the usecases are very different. — Alexandru Olaru, Oct 24 '17 at 10:35
Yeah, that's what I suspected. Is my implementation adequate? — uglycode, Oct 24 '17 at 10:48
The problem with your implementation is that you added the `data` in a higher scope than your promise, it will accumulate data for each `parse` use, if you use `parse` promise 2 times, the second use will have the first values appended and then the second values also. A better approach is to set the `let data` in the promise in this way for each use you will store only the new data. — Alexandru Olaru, Oct 24 '17 at 10:54
Have a look at https://stackoverflow.com/questions/43638105/how-to-get-synchronous-readline-or-simulate-it-using-async-in-nodejs — Bergi, Jun 05 '21 at 19:52

Jesús López · Answer 1 · 2022-03-21T18:57:53.773

Here you have a simple way to do it that doesn't use promisify:

const readline = require('readline').createInterface({
    input: process.stdin,
    output: process.stdout
});

function question(query) {
    return new Promise(resolve => {
        readline.question(query, resolve);
    });
}

async function main() {
    const name = await question('Whats your name? ');
    console.log(`hello ${name}!`);
    readline.close();
}

main();

score 5 · Answer 2 · edited Jul 01 '20 at 14:48

Here is an example of how I promisify readline.question:

const rl = require('readline');
const { promisify } = require('util');
const readline = rl.createInterface({
  input: process.stdin,
  output: process.stdout,
});

// Prepare readline.question for promisification
readline.question[promisify.custom] = (question) => {
  return new Promise((resolve) => {
    readline.question(question, resolve);
  });
};

// Usage example:
(async () => {
  const answer = await promisify(readline.question)('What is your name? ');
  readline.close();
  console.log('Hi %s!', answer);
})();

Node (v8) documentation for custom promisified functions: https://nodejs.org/dist/latest-v8.x/docs/api/util.html#util_custom_promisified_functions

score 0 · Answer 3 · answered Oct 24 '17 at 10:34

0

try to use bluebird which create http://bluebirdjs.com/docs/api/promise.promisifyall.html

but if the code works. then I think you don't need to promisify that since you already return it as promise.

answered Oct 24 '17 at 10:34

John Michael Villegas

328
2
6

Node.js - promisify readline

3 Answers3

Linked