Why are my PHP "if" conditions being ignored? Break/continue not working

Question

I have the following set of if/elseif conditions that update columns titled Col & Col2 when a form is submitted:

if($data3["Col"] < 2 ){

      $db->query("UPDATE answers SET Col = Col+1");

}elseif( $data3["Col"]= 2){
      $db->query("UPDATE answers SET Col = Col+0");
  }

if($data3["Col2"] < 10){

 $db->query("UPDATE answers SET Col2 = Col2+1");

}elseif( $data3["Col2"] >= 10){

      $db->query("UPDATE answers SET Col2 = Col2+0");
 }

When the code runs, it ignores the if/elseif conditions and does every update. For example, let's say upon form submit, Col = 2 & Col2 = 10. Col and Col2 should both stay stay the same. However, the code updates both by 1. I've tried every iteration that I can think of using continue, break, and return but nothing seems to work.

Any help would be much appreciated.

Thanks!

Your first `elseif` only contains a single `=`. You are assigning 2 to `$data3` rather than checking that it **equals** 2. — Obsidian Age, Jul 11 '17 at 04:36
If you dont want to update anything for `col = 2` and `col2 = 10` then why un-necessary update query is there — B. Desai, Jul 11 '17 at 04:43
Possible duplicate of [The 3 different equals](https://stackoverflow.com/questions/2063480/the-3-different-equals) — Qirel, Jul 11 '17 at 04:46
`if` conditions are not "ignored"; if you stop thinking like that you'll be able to more easily find your bugs — Lightness Races in Orbit, Jul 11 '17 at 12:10

score 1 · Accepted Answer · answered Jul 11 '17 at 04:35

1

You missed an equal to here

elseif($data3["Col"]==2)

answered Jul 11 '17 at 04:35

Joey Pinto

1,665
1
17
33

Oh, how vast a difference a petty comma does make. Thank you for your help :) – user3666954 Jul 11 '17 at 04:43
It says I need to wait a few minutes to accept. I'll accept when it lets me. – user3666954 Jul 11 '17 at 04:44
@user3666954: That is not a comma. – Lightness Races in Orbit Jul 11 '17 at 12:11

score 1 · Answer 2 · answered Jul 11 '17 at 04:38

1

Equal sign (=)is for assignment not for testing equality(==), so your elseif clause should be
$data3["Col"] == 2 instead of $data3["Col"]= 2;

if($data3["Col"] < 2 ){

      $db->query("UPDATE answers SET Col = Col+1");

}elseif( $data3["Col"]= 2){// not $data3["Col"]= 2 but this $data3["Col"] == 2
      $db->query("UPDATE answers SET Col = Col+0");
  }

Good luck

answered Jul 11 '17 at 04:38

kourouma_coder

1,030
2
13
21

Thank you for your help. Completely missed that extra = – user3666954 Jul 11 '17 at 04:43
That happens sometimes – kourouma_coder Jul 11 '17 at 04:44

score 1 · Answer 3 · answered Jul 11 '17 at 04:44

1

Instead of

elseif($data3["Col"]=2){ $db->query("UPDATE answers SET Col = Col+0");}

use this:

elseif($data3["Col"]==2){ $db->query("UPDATE answers SET Col = Col+0");}

answered Jul 11 '17 at 04:44

Nitish Kumar Diwakar

645
4
14
25

score -1 · Answer 4 · answered Jul 11 '17 at 04:51

-1

you don't need to used elseif for no action .. just try if for any action...

check $data3["Col2"] value. I think your problem is here..

answered Jul 11 '17 at 04:51

Amin Motamedi

1
3

Why are my PHP "if" conditions being ignored? Break/continue not working

4 Answers4