"Vector erase iterator outside range" error

Question

I am trying to run the below example provided in book to test the functionality, but getting an error regarding saying "Vector erase iterator outside range". I couldn't figure out what that means.

#include "stdafx.h"
#include <iostream>
#include <vector>

using namespace std;

int main() {
    using MyVector = vector<int>;
    MyVector newVector = { 0,1,2 };
    newVector.push_back(3);
    newVector.push_back(4);

    MyVector::const_iterator iter = newVector.cbegin() + 1;
    newVector.insert(iter, 5);
    newVector.erase(iter);

    for (auto iter = newVector.begin(); iter != newVector.end(); ++iter) {
        cout << *iter << endl;
    }

    return 0;
}

Did you put the error message into Google and read the results? — Lightness Races in Orbit, Jun 30 '17 at 17:26
related/dupe: https://stackoverflow.com/questions/6438086/iterator-invalidation-rules — NathanOliver, Jun 30 '17 at 17:26
read http://www.cplusplus.com/reference/vector/vector/insert/ about iterator validity — pm100, Jun 30 '17 at 17:38

score 0 · Accepted Answer · answered Jun 30 '17 at 17:41

0

After newVector.insert(iter, 5), iter is not valid. That's why insert returns an iterator. Your code should be

iter = newVector.insert(iter, 5);

answered Jun 30 '17 at 17:41

Pete Becker

72,338
6
72
157

Thanks for the guidance. – ajay ramgarhia Jul 01 '17 at 04:56

"Vector erase iterator outside range" error

1 Answers1

Linked