Is Dispose() necessary before recreating a large bitmap inside a loop?

Question

Suppose I have the code:

void Method1() {
    Bitmap bitmap1;
    foreach (string name in OpenFileDialog1.FileNames) {
        bitmap1 = new Bitmap(name);
        ... // process bitmap
        bitmap1.Dispose();
    }
}

Is Dispose() necessary inside the loop?

Possible duplicate of [.Net and Bitmap not automatically disposed by GC when there is no memory left](http://stackoverflow.com/a/5838632/448144) The marked answer should explain why you need to dispose of it. — Nope, Feb 23 '17 at 14:32

score 0 · Answer 1 · edited Feb 23 '17 at 15:38

0

Oh yeah. That bitmap object is holding a memory map open on the file!

Better method as this code structure can use using:

void Method1() {
    foreach (string name in OpenFileDialog1.FileNames) {
        using (var bitmap1 = new Bitmap(name))
        {
            ... // process bitmap
        }
    }
}

edited Feb 23 '17 at 15:38

Ðаn

10,679
11
60
94

answered Feb 23 '17 at 14:35

Joshua

38,744
8
68
123

1

`using` seems to be already covered in the linked duplicate too ► http://stackoverflow.com/a/5838649/448144 – Nope Feb 23 '17 at 14:49
Why declare bitmap1 with `var` and not with `Bitmap`? – Paulo Barretto Feb 23 '17 at 16:06
1

@PauloBarretto: I always use var when assigning at decl time. The typesystem will infer the correct type every time. – Joshua Feb 23 '17 at 16:15

Is Dispose() necessary before recreating a large bitmap inside a loop?

1 Answers1