Functions' order in C

Question

Why does my code work ? I am calling the function generateNumber before declaring it, and I haven't set a prototype at the beginning of the file, so normally it shouldn't work, should it ?

Here is my code :

#include <stdio.h>
#include <stdlib.h>
#include <time.h>


int main(int argc, const char * argv[]) {
    int max = 100;
    int min = 1;
    int mysteryNumber = generateNumber(min, max);
    int enteredNumber = min-1;
    do{
        printf("Enter a number !\n");
        scanf("%d", &enteredNumber);
        if (enteredNumber > mysteryNumber) {
            printf("It's less !");
        }else if(enteredNumber < mysteryNumber){
            printf("It's more !");
        }
    }while (enteredNumber != mysteryNumber);
    printf("Congratulations, the mystery number was %d \n", mysteryNumber);
    return 0;
}

int generateNumber(int min, int max){
    srand(time(NULL));
    return (rand() % (max - min + 1)) + min;
}

Thanks by advance !

http://stackoverflow.com/questions/8440816/warning-implicit-declaration-of-function — sabbahillel, Jan 12 '17 at 19:48
What do you mean by "work" exactly? It sounds like the program did not do what you expected it to do, which sounds like it's not working. — David Schwartz, Jan 12 '17 at 19:49
I suspect that you ignored your compiler's disgnostic messages, which told you that your program is invalid. — AnT, Jan 12 '17 at 20:13
This question is similar to the duplicate, but not identical, in that the duplicate uses implicit typing and does not use parameters at all. Voting to reopen. — Sergey Kalinichenko, Jun 27 '17 at 12:04

Sergey Kalinichenko · Accepted Answer · 2017-01-12T20:07:07.900

Surprisingly, this is one of the rare cases when it actually should work with old compilers - specifically, with compilers prior to C99. Still, you shouldn't do it: implicit int has been removed in C99, because it makes code fragile.

When a function lacks prototype, older C compilers used to assume that all its arguments match the types of expressions that you pass, and that their return type is int. Your function happens to match this description: you pass two integers, and treat the return value as an int.

score 1 · Answer 2 · edited Jan 12 '17 at 20:03

1

You are right it shouldn't work. My gcc (6.1.0) produces:

test.c: In function ‘main’:
test.c:9:25: warning: implicit declaration of function ‘generateNumber’ [-Wimplicit-function-declaration]
     int mysteryNumber = generateNumber(min, max);
                         ^~~~~~~~~~~~~~

It "works" because most compilers are permissive of this by providing an implicit function declaration. However, it's not valid in modern C.

Before C99 removed this implicit function declaration from the standard, it was allowed. But it's not valid anymore since C99. If your compiler doesn't provide warnings for this, try to increase the warning levels.

edited Jan 12 '17 at 20:03

melpomene

81,915
7
76
137

answered Jan 12 '17 at 19:46

P.P

112,354
20
166
226

http://stackoverflow.com/questions/8440816/warning-implicit-declaration-of-function Note that this is a warning only, so it will still compile. – sabbahillel Jan 12 '17 at 19:47
1

@sabbahillel C standard doesn't distinguish between warnings and errors -- only diagnostics. So, compiling with (or even without in some cases e.g. undefined behaviours) warnings isn't necessarily mean it's *valid* (per C standard). – P.P Jan 12 '17 at 19:49

Functions' order in C

2 Answers2