Stuck in infinite loop? (Java)

Question

New to programming and working on some Project Euler problems. I believe I'm stuck in an infinite loop. I've worked it out on paper and everything seems okay. What am I missing?

public class Euler2 {
    public static void main(String[] args) {
        int i = 1;
        int j = 2;
        int fib = 0;
        int sum = 2;

        //Sum of even Fibonacci numbers

        while(fib < 10);{
            fib = (i + j);
            if(fib % 2 == 0);{
                sum = sum + fib;
            }
            i = j; j = fib;
        }   
        System.out.println(sum);        
    }
}

First of all you should get rid of `;` in your `while` statement: `while(fib < 10);` — user2004685, Jan 04 '17 at 18:38
http://stackoverflow.com/questions/2610679/whats-wrong-with-this-while-loop — Michael, Jan 04 '17 at 18:39
Ditto for the `if(fib % 2 == 0);{` line (which should be `if (fib % 2 == 0) {`). — kevinji, Jan 04 '17 at 18:39
Aaaaand I'm an idiot. Just need a second (or more) set of eyes. Appreciate it! — Spanos, Jan 04 '17 at 18:43

score 1 · Answer 1 · answered Jan 04 '17 at 18:39

1

You have a semicolon between the while condition and the curly bracket that should not be there, perhaps this is what is causing the problem.

answered Jan 04 '17 at 18:39

OSteTs

92
5

3

Also a ; does not belong after the `if` statement... – CraigR8806 Jan 04 '17 at 18:40

R. Salame · Answer 2 · 2017-01-04T18:59:49.963

-1

This code should work.

public static void main(String[] args) {
    int i = 1;
    int j = 2;
    int fib = 0;
    int sum = 2;

    //Sum of even Fibonacci numbers

    while(fib < 10){
        fib = (i + j);
        System.out.println( "fib value is: " + fib); 

        if(fib % 2 == 0){
            sum = sum + fib;
        }
        i = j; j = fib;
    }   
    System.out.println("total sum is: " + sum);        
}

edited Jan 04 '17 at 18:59

answered Jan 04 '17 at 18:46

R. Salame

19
4

I meant logic errors. – R. Salame Jan 04 '17 at 18:59

Stuck in infinite loop? (Java)

2 Answers2