Creating PHP login system

Question

i am trying to build a login system with php , can anyone point me to my error in my code

<?php


session_start();

if(isset($_POST['loginbtn'])){

require_once 'index.php';
require_once 'Database_conx.php';

$emailbox         = $_POST ["loginemailbox"];
$loginpasswordbox = $_POST ["loginpasswordbox"];
$loginpasswordbox = md5($loginpasswordbox);
$result = mysqli_query($conn, 'SELECT * FROM Registration where Email = "'.$emailbox.'" and User_Password= "'.$loginpasswordbox.'" ');
if(mysqli_num_rows($result) == 1) {
    $_SESSION['loginemailbox'] = $emailbox;
    header('Location:home.php');

 }
}
?>

and the following html code is found on my index.php

<form id="login" action="login.php" method="post">
  <div id ="header_top_login">
   <input type="text" class ="form-control" placeholder = "Enter Email"    name = "loginemailbox" style="border :0px;">
                 </div>

     <div id = "header_top_password">
       <input type="password" class = "form-control" placeholder = "Enter Password" name = "loginpasswordbox" style = "border :0px">
                </div>

                <div id = "loginbutton">
                    <a href="login.php" type=" submit" name="loginbtn" class="btn btn-danger pull-right"  > Login</a>
                </div>

                <div id="forget_Password" >
                    <button type="button" class="btn btn-link">Forget your Password ?</button>
                </div>   
          </form>

can anyone tell me what am doing wrong.

it's not the login button.. it's the forgot password btn.. he was using `anchor` — Sam Teng Wong, Mar 28 '16 at 06:22
missed `double quote` after `$loginpasswordbox.'" '`. it should be `$loginpasswordbox.'" ' "`. — Yash, Mar 28 '16 at 06:22
@saty is right. And don't check form submit button. Test username and password inputs always. — Navid, Mar 28 '16 at 06:25
you should add else condition so that you can trace til where your code is raching — PRashant PUrohit, Mar 28 '16 at 06:29
thanks for the help guys . when i run the code it display's a blank page in the browser — B.Daddy, Mar 28 '16 at 06:49
Your code is vulnerable to SQL injection. Please read [How can I prevent SQL-injection in PHP?](http://stackoverflow.com/questions/60174/how-can-i-prevent-sql-injection-in-php) for information on how to fix it. — Matt Raines, Mar 28 '16 at 07:06

score 0 · Answer 1 · answered Mar 28 '16 at 06:30

0

For Submit button Use input instead of a tag. For example:

 <form action="demo_form.php">
   Username: <input type="text" name="usrname"><br>
   <input type="submit" value="Submit">
 </form>

answered Mar 28 '16 at 06:30

masoud sharifi

25
6

score 0 · Answer 2 · answered Mar 28 '16 at 06:45

i think you should replace this two line in login.php.

$emailbox         = $_POST ["loginemailbox"];
$loginpasswordbox = $_POST ["loginpasswordbox"];

with this.

$emailbox         = $_POST["loginemailbox"];
$loginpasswordbox = $_POST["loginpasswordbox"];

remove blank space.

Creating PHP login system

2 Answers2