unlink file from folder

Question

I can't unlink file from server folder.

Error Warning:

mysql_fetch_array() expects parameter 1 to be resource, boolean given on line 4.

PHP Code:

<?php
if($_GET['action'] = "deletelink" && !empty($_GET['id']) && is_numeric($_GET['id'])) {

    $result = mysql_query("DELETE FROM books WHERE id='".mysql_real_escape_string($_GET['id'])."' ");
    while ($a_row = mysql_fetch_array ($result) )
    {
    unlink("/home/me/public_html/upload/image/$a_row[image]");
    }
    mysql_query("DELETE FROM 1 WHERE fid='".mysql_real_escape_string($_GET['id'])."' ");
    mysql_query("DELETE FROM 2 WHERE fid='".mysql_real_escape_string($_GET['id'])."' ");
    mysql_query("DELETE FROM 3 WHERE fid='".mysql_real_escape_string($_GET['id'])."' ");
    mysql_query("DELETE FROM 4 WHERE fid='".mysql_real_escape_string($_GET['id'])."' ");

}

I don't think a delete query returs data for an array fetch. — Matt, Dec 27 '15 at 10:47
@Basheer Ahmed Like this - if($_GET['action'] = "deletelink" && !empty($_GET['id']) && is_numeric($_GET['id']) && $result !== NULL) { — ama rullz amarullzz, Dec 27 '15 at 10:48

Jan · Accepted Answer · 2015-12-27T11:24:45.023

1

There are a couple of issues with your code:

You do not fetch anything from the database first
Using the deprecated mysql_ functions
Using multiple DELETE questions (can they be combined somehow?)
The comparison $_GET['action'] = 'deletelink' is not a comparison at all (and always true as it is an assignment).

Concerning your issue, you must select the data first like so:

<?php
if($_GET['action'] == "deletelink" && !empty($_GET['id']) && is_numeric($_GET['id'])) {
    // you need to fetch the result first!
    $result = mysql_query("SELECT * FROM books WHERE id='".intval($_GET['id']);

    while ($row = mysql_fetch_array ($result) )
        unlink("/home/me/public_html/upload/image/{$row['image']}");
    // here come your delete statements
}

edited Dec 27 '15 at 11:24

answered Dec 27 '15 at 11:11

Jan

40,932
8
45
77

Yes it works! Thanks Why here is used brackets {$row['image']} ? – ama rullz amarullzz Dec 27 '15 at 11:31
Also you said combination of delete queries into one how can ? – ama rullz amarullzz Dec 27 '15 at 11:41
@amarullzamarullzz The brackets are for use in doouble quotes, concerning your second question, there's an answer here on SO: http://stackoverflow.com/questions/3331992/how-to-delete-from-multiple-tables-in-mysql – Jan Dec 27 '15 at 12:00
Ok thanks! I have and thumbs folder when I add another unlink("/home/me/public_html/upload/image/thumbs/{$row['image']}"); Error: Warning: unlink(/home/me/public_html/upload/image/thumbs/): Is a directory. – ama rullz amarullzz Dec 27 '15 at 12:03
I've solded by adding { } onto while. – ama rullz amarullzz Dec 27 '15 at 12:46

score 0 · Answer 2 · answered Dec 27 '15 at 11:10

Simple print whether you get records from database and also if you get record, do you get filepath...see the printing code below with =======>

<?php

 if($_GET['action'] = "deletelink" && !empty($_GET['id']) && is_numeric($_GET['id'])) {

     $result = mysql_query("DELETE FROM books WHERE id='".mysql_real_escape_string($_GET['id'])."' ");


//=======>print to check if records are returned by database otherwise while loop won't be executed below
echo mysql_num_rows($result);

while ($a_row = mysql_fetch_array ($result) )
{

//=======>print this path and check if file exists on this path
echo "/home/me/public_html/upload/image/$a_row[image]";

 unlink("/home/me/public_html/upload/image/$a_row[image]");
}
                mysql_query("DELETE FROM 1 WHERE fid='".mysql_real_escape_string($_GET['id'])."' ");
                mysql_query("DELETE FROM 2 WHERE fid='".mysql_real_escape_string($_GET['id'])."' ");
                mysql_query("DELETE FROM 3 WHERE fid='".mysql_real_escape_string($_GET['id'])."' ");
                mysql_query("DELETE FROM 4 WHERE fid='".mysql_real_escape_string($_GET['id'])."' ");

        }

This won't work, unfortunately. Did you ever get something back from a `DELETE` statement? Additionally, there are some other issues with the code as well. — Jan, Dec 27 '15 at 11:23

unlink file from folder

2 Answers2