PHP Mysql how to show message when query return no result?

Question

i just trying to create php form

   <?php 

    $category = $_POST['category'];  
    $length = $_POST['length'];  
    $con = mysql_connect("localhost","globalex","[?H~hS=Oc=ES");
     $db = mysql_select_db("globalex",$con);
     $query = "SELECT list FROM answers WHERE category = '$category' AND length =    '$length'";
    $result = mysql_query($query);
    while($row = mysql_fetch_array($result)) {
    echo 'Category '. $category .' '. $length .' letters: ';
    echo '<b>'. $row['0'].'</b><br>';
    } 
    ?>

how to add message not found when the query has no result? thank you.

Good 'ol `if{...} else{...}`. – Funk Forty Niner Nov 26 '15 at 16:12 — Funk Forty Niner, Nov 26 '15 at 16:12

score 1 · Accepted Answer · edited May 23 '17 at 10:27

1

You shouldn't use the mysql_ functions anymore the are deprecated and don't allow you to use parameterized queries which will prevent you from being SQL injected.

Here's a way using the mysql_ functions. You can easily transistion this to mysqli or pdo because they both have the num_rows function just check the manual for their implementation.

$category = mysql_real_escape_string($_POST['category']);  
$length = mysql_real_escape_string($_POST['length']);  
$con = mysql_connect("localhost","globalex","[?H~hS=Oc=ES");
 $db = mysql_select_db("globalex",$con);
 $query = "SELECT list FROM answers WHERE category = '$category' AND length =    '$length'";
$result = mysql_query($query) or die(mysql_error());
if(mysql_num_rows($result) == 0) {
      echo "No Results";
} else { 
     while($row = mysql_fetch_array($result)) {
           echo 'Category '. $category .' '. $length .' letters: ';
           echo '<b>'. $row['0'].'</b><br>';
     }
}

You can read more about SQL injection prevention here, How can I prevent SQL injection in PHP? and more about why the mysql_ functions shouldn't be used here Why shouldn't I use mysql_* functions in PHP?.

edited May 23 '17 at 10:27

Community

1
1

answered Nov 26 '15 at 16:02

chris85

23,591
7
30
47

1

Sidenote: `if(mysql_error()) {` - `die(mysql_error());` no need to use that function twice. `if(!$result){...}` would work nicely. – Funk Forty Niner Nov 26 '15 at 16:15
Or narrow it down to `$result = mysql_query($query) or die(mysql_error());` – Funk Forty Niner Nov 26 '15 at 16:16
@Fred-ii- Good point, thanks. – chris85 Nov 26 '15 at 23:36
@BudiAndug If this worked for you please be sure to accept the answer. Also I'll post an update to incorporate what Fred has pointed out here. – chris85 Nov 26 '15 at 23:36
You're welcome Chris. – Funk Forty Niner Nov 26 '15 at 23:56

score 0 · Answer 2 · edited Nov 26 '15 at 16:17

<?php 

$category = $_POST['category'];  
$length = $_POST['length'];  
$con = mysql_connect("localhost","globalex","[?H~hS=Oc=ES");
 $db = mysql_select_db("globalex",$con);
 $query = "SELECT list FROM answers WHERE category = '$category' AND length =    '$length'";
$result = mysql_query($query);
if(mysqli_num_rows($result)>0){
while($row = mysql_fetch_array($result)) {
echo 'Category '. $category .' '. $length .' letters: ';
echo '<b>'. $row['0'].'</b><br>';
} 

}else{
echo 'no result';}
?>

PHP Mysql how to show message when query return no result?

2 Answers2