PHP Notice: Trying to get property of non-object in post.php on line 8

Question

I'm getting this error

PHP Notice: Trying to get property of non-object in post.php on line 8

on the code below

<?php
if (is_numeric($_GET["id"])) {
    $mysqli=mysqli_connect("localhost","xxx","xxx","xxx");
    $query = $mysqli->query("SELECT n FROM table WHERE o=".$_GET["id"]);
    if ($query) {
        if ($query->num_rows === 0) {
                header("HTTP/1.1 301 Moved Permanently"); 
                header("Location: http://www.example.com/?p=".$query->fetch_object()->n);
        }
    }
    mysqli_close($mysqli);
}
else {
    echo $_GET["id"];

}
?>

Any idea what's happening? I presumed the checks I had in place would ensure only valid data was being passed

Thanks

Here `fetch_object()` is not an object here. use `fetch_object()` like `while ($obj = $result->fetch_object()) {` and then use `$obj->n` — Ashish Choudhary, Nov 24 '15 at 08:54
you have `num_rows` === 0 and then try to fetch an object from 0 rows — Tanuel Mategi, Nov 24 '15 at 08:56
@BasheerAhmed his table has a different name, this is just simplified, as stated in a comment on a question below. also, 900 != 9k ;) — Tanuel Mategi, Nov 24 '15 at 08:59
@TanuelMategi If that was not the case then why he accepted that as an answer.. — Basheer Kharoti, Nov 24 '15 at 09:01
@BasheerAhmed the main answer is `while loop` check `updated` part of answer — Saty, Nov 24 '15 at 09:03
@BasheerAhmed look at the comments then: `It's not actually table in my proper code - didn't want to give out my real table name – pee2pee` The update got accepted — Tanuel Mategi, Nov 24 '15 at 09:04

Saty · Accepted Answer · 2015-11-24T09:02:08.427

2

table is reserved keyword in mysql it must be in backtict. Your query fails to give result that's the reason you are getting this error

SELECT n FROM `table` WHERE o=".$_GET["id"]

UPDATED

for fetching data you have to use while loop

while ($obj = $query->fetch_object()) {
            header("Location: http://www.example.com/?p=".$obj->n);
    }

Check http://php.net/manual/en/mysqli-result.fetch-object.php

edited Nov 24 '15 at 09:02

answered Nov 24 '15 at 08:46

Saty

22,213
7
30
49

1

It's not actually table in my proper code - didn't want to give out my real table name – pee2pee Nov 24 '15 at 08:48
PHP Parse error: syntax error, unexpected '->' – pee2pee Nov 24 '15 at 08:56
1

Ahh my bad forget `$` in obj check updated – Saty Nov 24 '15 at 08:57
D'oh - should have seen it my side as well – pee2pee Nov 24 '15 at 08:57

Tanuel Mategi · Answer 2 · 2015-11-24T08:55:24.827

0

you are trying to handle an empty result. you ask if the result has 0 rows, then try to fetch a row tho the result must be 0 rows:

if ($query->num_rows === 0) { // num_rows === 0
    header("HTTP/1.1 301 Moved Permanently");         //fetch with 0 rows?
    header("Location: http://www.example.com/?p=".$query->fetch_object()->n);
}

edited Nov 24 '15 at 08:55

answered Nov 24 '15 at 08:49

Tanuel Mategi

1,251
6
13

Tried that but no go for whatever reason – pee2pee Nov 24 '15 at 14:01

PHP Notice: Trying to get property of non-object in post.php on line 8

2 Answers2