Spring @Transactional annotation is not working

Question

I'm trying to run entityManager.merge(myEntity) within the following method but it seems that the @Transactional annotation is ignored. The Hibernate configuration seems to be fine because I can successfully fetch data from the db but it's not possible to write to the db. I'm using Spring version 3.2.3. Why are the writing db operations not working?

my method that does not work

package  com.reflections.importer.bls;
...

@Service
class BlsGovImporter {

...

    @Transactional
    private void importSeries(String externalId) {
        // This works. The dao is using EntityManager too
        Series series = seriesDao.findByExternalId(externalId);

        series.getValues().addAll(fetchNewValues());

        // This does not work and no exception is thrown 
        entityManager.merge(series);
    }

In which package your class BlsGovImporter is located ? In "com.reflections" ? — Lukasz Ciesluk, Aug 22 '15 at 13:28

luboskrnac · Accepted Answer · 2015-08-22T15:07:16.227

15

Because it is used on private method. Spring Docs:

Method visibility and @Transactional

When using proxies, you should apply the @Transactional annotation only to methods with public visibility. If you do annotate protected, private or package-visible methods with the @Transactional annotation, no error is raised, but the annotated method does not exhibit the configured transactional settings. Consider the use of AspectJ (see below) if you need to annotate non-public methods.

When its private, it is obviously called from within the same class. But Spring call needs to go through proxy in order to make it working. So the method will need to be called from another bean.

Other option is to annotate class with @Transactional.

edited Aug 22 '15 at 15:07

answered Aug 22 '15 at 14:33

luboskrnac

22,667
9
77
88

3

Even if it was public, if it is called from another method of same class, it would not use the proxy and the @Transactional would also be ignored – Serge Ballesta Aug 22 '15 at 14:51
2

Making the method public has firstly not solved my problem. But putting additionally the @Transactional annotation to an other method, that is not called from the same class has finally solved my problem. Now I'm considering to use aspectj – eztam Aug 22 '15 at 15:04
1

@SergeBallesta, you are correct, I updated my answer. – luboskrnac Aug 22 '15 at 15:07
There are several options to use @Transactional from the same class: 1. Configure Spring to use AspectJ instead of Spring AOP 2. Self-Autowire the bean and call the method via the injected reference [See here for more info](https://stackoverflow.com/questions/3423972/spring-transaction-method-call-by-the-method-within-the-same-class-does-not-wo) – eztam Mar 02 '20 at 17:00

score 1 · Answer 2 · answered Oct 28 '19 at 06:59

luboskrnac actualy answered it exactly for me, but just adding this to Spring newbie who might be confused on using proxy or not.

Please refer to this page explaining the case where even if you call an @Transactional method within the same class, since you call it without the same class, it will not be called via proxy.

https://www.logicbig.com/tutorials/spring-framework/spring-data-access-with-jdbc/correct-use-of-declarative-transaction.html

Spring @Transactional annotation is not working

2 Answers2

Linked