Remove last comma from string in while loop

Question

My select query is like this, in group_name i am giving comma but I want to remove comma from last. I already tried with trim but it removes all commas, and I want to remove last comma only.

$selctGroup = "SELECT contact_id,group_name FROM contact_group
                       LEFT JOIN `group` ON `group`.`group_id` = `contact_group`.`group_id`
                 WHERE contact_id = ".$row['contact_id'];
 $selctGroupRes = mysql_query($selctGroup);
 while($groupRow = mysql_fetch_array($selctGroupRes))
 {
   echo  $groupRow['group_name'].','; 
 }

Check answer here: http://stackoverflow.com/questions/5592994/remove-the-last-character-from-string — ErdraugPl, May 20 '15 at 10:39
yes i am sure echo rtrim($groupRow['group_name'],','); @panther — Prashant Bhatt, May 20 '15 at 10:41

score 3 · Accepted Answer · answered May 20 '15 at 10:46

Instead of echoing out each line, build up a string to echo at the end. Before that, remove the lingering comma from the end with rtrim($str,",").

$str = "";
while($groupRow = mysql_fetch_array($selctGroupRes)) {
   $str .= $groupRow['group_name'].','; 
}
echo rtrim($str,",");

score 1 · Answer 2 · answered May 20 '15 at 10:55

$selctGroup = "SELECT contact_id,group_name FROM contact_group
                       LEFT JOIN `group` ON `group`.`group_id` = `contact_group`.`group_id`
                 WHERE contact_id = ".$row['contact_id'];
 $selctGroupRes = mysql_query($selctGroup);
 $str='';
 while($groupRow = mysql_fetch_array($selctGroupRes))
 {
    if($str=='')
      $str=$groupRow['group_name']; 
    else
       $str.=','.$groupRow['group_name']; 
 }
 echo $str;

Saty · Answer 3 · 2015-05-20T10:46:37.427

0

Store your data in array and using implode you can remove last comma

while($groupRow = mysql_fetch_array($selctGroupRes))
 {
  $result[] = $groupRow['group_name']; 
 }

echo implode(",", $result);

edited May 20 '15 at 10:46

answered May 20 '15 at 10:40

Saty

22,213
7
30
49

with this output is like this Test,,Test2,,test 3,,test 4 , – Prashant Bhatt May 20 '15 at 10:44
dont append comma within loop – Makesh May 20 '15 at 10:46
@Makesh thanks i understand my problem and correct it – Saty May 20 '15 at 10:48

score 0 · Answer 4 · answered May 20 '15 at 10:40

0

Using rtrim().Like below

rtrim($groupRow['group_name'])

answered May 20 '15 at 10:40

Mahadeva Prasad

689
7
19

should be `rtrim($groupRow['group_name'],",");` your code will only remove the white spaces at the right side of the string – roullie May 20 '15 at 10:42
yes after my loop i have to put this code echo rtrim($str,","); @Prasad – Prashant Bhatt May 20 '15 at 10:52

Remove last comma from string in while loop

4 Answers4