32

I have a function that resembles the one below. I'm not sure how to use the os module to get back to my original working directory at the conclusion of the jar's execution.

def run(): 
    owd = os.getcwd()
    #first change dir to build_dir path
    os.chdir(testDir)
    #run jar from test directory
    os.system(cmd)
    #change dir back to original working directory (owd)

note: I think my code formatting is off - not sure why. My apologies in advance

Daniel Spiewak
  • 53,503
  • 12
  • 106
  • 120
Amara
  • 13,013
  • 9
  • 31
  • 27
  • If you put four spaces before each line of your code, SO will format it more nicely. – sep332 Nov 18 '08 at 17:22
  • I just fixed that for @Amara :) .. they had used a
     tag to open, but a  to end. It's all clean and happy now, though :D
    – warren Nov 18 '08 at 17:23
  • Also answered in http://stackoverflow.com/questions/299249/how-can-i-get-my-python-version-25-script-to-run-a-jar-file-inside-a-folder-ins. – S.Lott Nov 18 '08 at 17:52

6 Answers6

57

A context manager is a very appropriate tool for this job:

from contextlib import contextmanager

@contextmanager
def cwd(path):
    oldpwd=os.getcwd()
    os.chdir(path)
    try:
        yield
    finally:
        os.chdir(oldpwd)

...used as:

os.chdir('/tmp') # for testing purposes, be in a known directory
print 'before context manager: %s' % os.getcwd()
with cwd('/'):
    # code inside this block, and only inside this block, is in the new directory
    print 'inside context manager: %s' % os.getcwd()
print 'after context manager: %s' % os.getcwd()

...which will yield something like:

before context manager: /tmp
inside context manager: /
after context manager: /tmp

This is actually superior to the cd - shell builtin, inasmuch as it also takes care of changing directories back when a block is exited due to an exception being thrown.


For your specific use case, this would instead be:

with cwd(testDir):
    os.system(cmd)

Another option to consider is using subprocess.call() instead of os.system(), which will let you specify a working directory for the command to run:

# note: better to modify this to not need shell=True if possible
subprocess.call(cmd, cwd=testDir, shell=True)

...which would prevent you from needing to change the interpreter's directory at all.

Charles Duffy
  • 257,635
  • 38
  • 339
  • 400
29

You simply need to add the line:

os.chdir(owd)

Just a note this was also answered in your other question.

grieve
  • 12,560
  • 10
  • 48
  • 59
  • Noted. :) I Wanted to ensure my question was more specific and detailed in order to get the best help and also, post a code sample to add some more clarity to my question. – Amara Nov 18 '08 at 17:41
15

The advice to use os.chdir(owd) is good. It would be wise to put the code which needs the changed directory in a try:finally block (or in python 2.6 and later, a with: block.) That reduces the risk that you will accidentally put a return in the code before the change back to the original directory.

def run(): 
    owd = os.getcwd()
    try:
        #first change dir to build_dir path
        os.chdir(testDir)
        #run jar from test directory
        os.system(cmd)
    finally:
        #change dir back to original working directory (owd)
        os.chdir(owd)
Alex Coventry
  • 65,015
  • 4
  • 35
  • 39
3

A context-manager is overkill for this situation (executing a system command). The best solution is to use the subprocess module instead (Python 2.4 onwards) and the run or popen methods with the cwd argument.

So, your code can be replaced with:

def run(): 
    #run jar from test directory
    subprocess.run(cmd, cwd=testDir)

See https://bugs.python.org/issue25625 and https://docs.python.org/3/library/subprocess.html#subprocess-replacements.

Nzbuu
  • 5,182
  • 29
  • 49
2

os.chdir(owd) should do the trick (like you've done when changing to testDir)

1

Python is case sensitive so when typing the path make sure it's the same as the directory you want to set.

import os

os.getcwd()

os.chdir('C:\\')
bluish
  • 24,718
  • 26
  • 114
  • 174
eagle3ye
  • 11
  • 1
  • I'm not sure it is Python that is case sensitive, I think it's the operating system that is (Linux, etc). – Flimm Jan 14 '22 at 15:31