Select All MySQL Rows

Question

I have the following code which choose all rows in MYSQL but it show the last row only

    $query = mysql_query("SELECT * FROM `users`") or die(mysql_error());
     while ( $row = mysql_fetch_assoc($query) )
          {
          $token = $row['instagram_access_token'];
          }
          echo "$token";

You're only storing the last row. Make $m an array or concatenate it. — chris85, Apr 25 '15 at 16:49
You can use $m[]=$row['instagram_access_token']; and use print_r($m) as @chris85 suggested. — RN Kushwaha, Apr 25 '15 at 16:53
You shouldn't be using mysql_* functions because they are depreciated, see http://stackoverflow.com/questions/12859942/why-i-shouldnt-use-mysql-functions-in-php — BRBT, Apr 25 '15 at 16:57

score 1 · Answer 1 · edited May 23 '17 at 12:28

1

Your code echo last row because, within while loop every time you overwrites $token value with new value. Try to connect using PDO & assign variable to array like this.

 $token=[];
 $user='your_user_name';
 $pass='your_password';
 $conn= new PDO('mysql:host=your_host_name;dbname=your_db_name', $user, $pass);
 $query = $conn->prepare('SELECT * FROM `users`');
 $query->execute();
// alternatively you could use PDOStatement::fetchAll() and get rid of the loop
while ($row = $query->fetch(PDO::FETCH_ASSOC)) {
    $token[] = $row['instagram_access_token']; // see this line with []
}

 echo '<pre>';
 print_r($token);
 echo '</pre>';

Note: Don't use mysql_* see more here Why shouldn't I use mysql_* functions in PHP?

edited May 23 '17 at 12:28

Community

1
1

answered Apr 25 '15 at 16:53

Always Sunny

32,751
7
52
86

1

@BigRabbit OP is using mysql_* this is just an answer to the question. – chris85 Apr 25 '15 at 17:02
@chris85, yaap , i know , i am going to edit my answer & put the total connection code with `PDO`, thanx – Always Sunny Apr 25 '15 at 17:05
1

@BigRabbit Is answering a question for the general public better than answering the specific question asked? I think noting the user should use mysqli or PDO sufficed. – chris85 Apr 25 '15 at 17:56

score -1 · Answer 2 · answered Apr 25 '15 at 16:50

-1

Change your code to this:

$query = mysql_query("SELECT * FROM `users` ORDER BY RAND()") or    
    die(mysql_error());
while ( $row = mysql_fetch_assoc($query) )
{
    $m = $row['instagram_access_token'];
    echo "$m";
}

answered Apr 25 '15 at 16:50

Lelio Faieta

6,242
6
38
64

Why not simply echo $row['instagram_access_token'];? Why to assign to $m just for echo ? – RN Kushwaha Apr 25 '15 at 16:52
Concatenate or make it an array I think is a better solution. Then it will be accessible later if needed. – chris85 Apr 25 '15 at 16:52
You can echo directly or maybe the question is simplified and instead of echoing the user needs to do something else with that data – Lelio Faieta Apr 25 '15 at 16:53
2

@LelioFaieta - yes; but the values in `$row` are re-set every time the loop runs. If you want to access them outside the loop, then assigning the contents to another array will let you do that. – andrewsi Apr 25 '15 at 16:58

Select All MySQL Rows

2 Answers2