jQuery beginner ".each()"

Question

Why do I get an error in the console? "Uncaught SyntaxError: Unexpected token ;"

jQuery:

$("#menu a").each(function(){ 
console.log(($this.attr("href"));
});

HTML:

<body>
<div id="menu">
    <ul>
        <li class="selected"><a href="index.html">Home</a></li>
        <li><a href="about.html">About</a></li>
        <li><a href="contact.html">Contact</a></li>
        <li><a href="support.html">Support</a></li>
        <li><a href="faqs.html">FAQs</a></li>
        <li><a href="events.html">Events</a></li>
    </ul>
</div>

@LShetty note that `this.href` will give you the absolute URL in some cases, which may not be what the OP requires. `attr` gives you the exact string of the attribute. — Rory McCrossan, Mar 05 '15 at 13:24
You have an extra opening parentheses in your `console.log()`; — Jay Blanchard, Mar 05 '15 at 13:25

score 4 · Accepted Answer · answered Mar 05 '15 at 13:22

4

You have mis-matched brackets, and $this should be $(this):

$("#menu a").each(function(){
    console.log($(this).attr("href"));
});

answered Mar 05 '15 at 13:22

Rory McCrossan

319,460
37
290
318

Dhiraj · Answer 2 · 2015-03-05T13:29:41.953

1

It should be $(this) and not $this.

And also you have an extra parentheses opened inside console.log

Something like this

$("#menu a").each(function(){ 
  console.log($(this).attr("href"));
});

edited Mar 05 '15 at 13:29

answered Mar 05 '15 at 13:22

Dhiraj

32,144
8
59
77

score 0 · Answer 3 · answered Mar 05 '15 at 13:24

0

Try this Working Demo

$("#menu ul li a").each(function(){ 
console.log(($(this).attr("href")));
})

answered Mar 05 '15 at 13:24

I'm Geeker

4,646
5
20
40

score 0 · Answer 4 · answered Mar 05 '15 at 13:24

0

Simply use this.href

$("#menu a").each(function(){
    //to grab the absolutel URL
    console.log( this.href );
    //To get the string from href
    console.log ( $(this).attr("href") );
});

answered Mar 05 '15 at 13:24

lshettyl

8,016
4
23
30

i'm still confused this vs $(this) – causita Mar 05 '15 at 13:35
@causita, right, take a look at [the answer here](http://stackoverflow.com/questions/3633270/difference-between-this-and-this-in-jquery) – lshettyl Mar 05 '15 at 13:42

score 0 · Answer 5 · answered Mar 05 '15 at 13:24

0

$this will return that kind of error since it's not defined while $(this) refers to each individual link (<a href="#">) and will work just fine.

answered Mar 05 '15 at 13:24

prototype

3,163
2
25
42

jQuery beginner ".each()"

5 Answers5