Optimization of multple if condition in python

Question

I have a python condition statement like this

if 'small_cover' not in request.POST or 'medium_cover' not in request.POST or 'large_cover' not in request.POST:
    # do somethinf here.

Can there be the shortest way than this.

What framework provides the `request.POST` object? Is this Django, for example? — Martijn Pieters, Jan 31 '15 at 11:10
`if not all(thing in request.POST for thing in ('small_cover', ...)):`? — jonrsharpe, Jan 31 '15 at 11:11
@wrufesh: no, it is an *object that acts like a dictionary*. It depends *heavily* on what type of object it really is what answers I can give you. — Martijn Pieters, Jan 31 '15 at 11:19
If it *is* just a dictionary, this question is a duplicate. But the best way to do this with a true dictionary may not be the best way to do it with, say, a Werkzeug MultiDict object. — Martijn Pieters, Jan 31 '15 at 11:31
I've now dupe-hammered this to the canonical multiple-keys-in-dictionary post, as the answers here did not add anything new to the discussion. — Martijn Pieters, Jan 31 '15 at 11:42

score 1 · Answer 1 · answered Jan 31 '15 at 11:16

1

if not all(x in request.POST for x in ('small_cover', 'medium_cover', 'large_cover')):

or even more concisely:

if not all(x+'_cover' in request.POST for x in ('small', 'medium', 'large')):

answered Jan 31 '15 at 11:16

khelwood

Padraic Cunningham · Answer 2 · 2015-01-31T11:44:46.540

1

Just use any which will short circuit if we find any of the three items are not in request.POST

if  any(x not in request.POST for x in ('small_cover',  'medium_cover','large_cover')):

edited Jan 31 '15 at 11:44

answered Jan 31 '15 at 11:17

2 Answers2