Undefined index Notice

Question

I've tried to fix this for ages, but when I try to upload a file I get an "undefined index" notice. Any help would be great! I get the error on line 38 if that helps, also I think it might be something to do with my form too.

HTML form:

    <form action="UploadFileCodeImage.php" method="post"enctype="multipart/form-data">
    Upload image (JPG, JPEG, PNG, or GIF):<br/>
    <input type="file" name="file" id="file"><br/>
    <input type="submit" value="submit" name="file">
    </form>

PHP:

<?php
$destination = "C:\xampp\htdocs\Uploaded files\CS\Image";
$target_file = $destination . basename($_FILES["file"]["name"]);
$uploadOk = 1;
$filetype = pathinfo($target_file,PATHINFO_EXTENSION);
// Check if image file is a actual image or fake image
if(isset($_POST["submit"])) {
    $check = filesize($_FILES["file"]["Temp"]);
    if($check !== false) {
        echo "Voila! - " . $check["file"];
        $uploadOk = 1;
    } else {
        echo "Error!";
        $uploadOk = 0;
    }
}
// Check if file already exists
if (file_exists($target_file)) {
    echo "Sorry, file already exists.";
    $uploadOk = 0;
}
// Check file size
if ($_FILES["file"]["size"] > 50000000) {
    echo "Sorry, your file is too large.";
    $uploadOk = 0;
}
// Allow certain file formats
if($filetype != "jpg" && $filetype != "png" && $filetype != "jpeg"
&& $filetype != "gif") {
    echo "Sorry, only JPG, JPEG, PNG, and GIF files are allowed.";
    $uploadOk = 0;
}
// Check if $uploadOk is set to 0 by an error
if ($uploadOk == 0) {
    echo "Sorry, your file was not uploaded.";
// if everything is ok, try to upload file
} else {
    if (move_uploaded_file($_FILES["file"]["Temp"], $target_file)) {
        echo "The file ". basename( $_FILES["file"]["name"]). " has been uploaded.";
    } else {
        echo "Error!";
    }
}
?>

This is wrong `["Temp"]` - [RTFM](http://php.net/manual/en/function.move-uploaded-file.php) — Funk Forty Niner, Jan 25 '15 at 00:16
Oh and this will never fire up anything `if(isset($_POST["submit"]))` - have you not done any basic debugging? Not to mention two elements holding the same name attribute. — Funk Forty Niner, Jan 25 '15 at 00:19
Ah thanks, I have next to none experience with this. Do you know exactly what's making it return undefined index? — DorsVenabili, Jan 25 '15 at 00:30
You're welcome. The answers are in my comments and 1/2 of which can be found in 2 of the answers below, where each are only 50% right. ;-) — Funk Forty Niner, Jan 25 '15 at 00:31
I decided to post an answer and you can view it below. @DorsVenabili — Funk Forty Niner, Jan 25 '15 at 00:42
@DorsVenabili If you didn't already saw it you can take a tour here: http://stackoverflow.com/tour and see how the site works! BTW: You can accept the answer how helped you the most and solved your problem(http://meta.stackexchange.com/q/5234)! — Rizier123, Jan 25 '15 at 00:46
@DorsVenabili I've spotted a few more errors and have made the appropriate edit in my answer, should you have seen it before my edit. Reload the answer to see the changes. — Funk Forty Niner, Jan 25 '15 at 01:06

score 1 · Accepted Answer · edited Jan 25 '15 at 02:22

1

Let me outline the errors in your code.

You have two form elements bearing the same name, "file"; that's a conflict.

<input type="file" name="file" id="file">
                   ^^^^^^^^^^^

and

<input type="submit" value="submit" name="file">
                                    ^^^^^^^^^^^

Then your conditional statement if(isset($_POST["submit"])) is based on a submit button being named "submit"; it doesn't exist, so nothing in there will be executed.

Therefore, rename your submit button to that, "submit".

Then you have ["Temp"] which is invalid, all of those should read as ["tmp_name"] as per the manual:

http://php.net/manual/en/function.move-uploaded-file.php

which is present in

$check = filesize($_FILES["file"]["Temp"]);

and

if (move_uploaded_file($_FILES["file"]["Temp"], $target_file)) {

Then there's this line:

$destination = "C:\xampp\htdocs\Uploaded files\CS\Image";

there should be two trailing slashes (edit)

$destination = "C:\xampp\htdocs\Uploaded files\CS\Image\\";

since $destination . basename($_FILES["file"]["name"] will translate as folderImage.jpg where it should be folder/Image.jpg, otherwise it will result in an error.

Also make sure that the destination folder has proper permissions to write to.

edited Jan 25 '15 at 02:22

deceze

491,798
79
706
853

answered Jan 25 '15 at 00:41

Funk Forty Niner

74,372
15
66
132

Thank you very much, my code now works. – DorsVenabili Jan 25 '15 at 01:13
1

@DorsVenabili You're welcome. Please accept the answer to mark it as solved. Here's how http://meta.stackexchange.com/a/5235 then come back and do the same thing with the answer I gave. :) cheers and welcome to Stack. – Funk Forty Niner Jan 25 '15 at 01:14
`..Image\\"`, or else syntax errors. – deceze Jan 25 '15 at 02:14
@deceze Thank you, I've made an edit to that effect. – Funk Forty Niner Jan 25 '15 at 02:15
Also, the condition at the end was correct already! Your "fixed" version will always be `false`. – deceze Jan 25 '15 at 02:16
@deceze You mean in regards to the `&&`? `if($filetype != "jpg" || $filetype != "png" || $filetype != "jpeg"` etc? – Funk Forty Niner Jan 25 '15 at 02:16
Yes. *Not X and not Y and not Z* is correct; *not X or not Y or not Z* will always match because something can't be X, Y and Z at the same time. – deceze Jan 25 '15 at 02:17
@deceze Ok, I understand what you mean. I didn't explain myself properly and is what I meant to write. I've made an edit, thanks again. – Funk Forty Niner Jan 25 '15 at 02:19
I don't care about the explanation, your *code* is wrong! – deceze Jan 25 '15 at 02:20
@deceze I'm not catching then. Please feel free to make an edit. OP accepted the answer so I don't know what else I should be doing or not doing. – Funk Forty Niner Jan 25 '15 at 02:21
OK, fixed it for you. – deceze Jan 25 '15 at 02:22

Steve Lloyd · Answer 2 · 2015-01-25T00:30:52.633

-1

"Temp" is not a valid key. Instead, use tmp_name

if (move_uploaded_file($_FILES["file"]["Temp"], $target_file)) {

should be

if (isset($_FILES["file"]["tmp_name"]) && move_uploaded_file($_FILES["file"]["tmp_name"], $target_file)) {

edited Jan 25 '15 at 00:30

answered Jan 25 '15 at 00:20

Steve Lloyd

643
1
12
27

1

and this is 50% right. – Funk Forty Niner Jan 25 '15 at 00:27

Undefined index Notice

2 Answers2