Remove last comma from a PhP variable(output)

Question

I have a PhP variable like

<?php 
  $query=mysql_query("SELECT * FROM visited_city WHERE username='$user' LIMIT 3");     

  while($row=mysql_fetch_assoc($query)){ 
     $city=$row['city']; 

     echo '<a href="'.$city.'">'.$city.', </a>'; 
  }
?>

Results=

Dhaka, Delhi, Mumbai,

Actually, I want like

Dhaka, Delhi, Mumbai

I am sorry, there are so many answers I found but did not match me...

Check this http://stackoverflow.com/questions/5592994/remove-last-character-from-string — Naincy, Nov 17 '14 at 12:34
Naincy Gupta, in this situation the string is already being output. Therefore your link doesn't help. — Death By Penguin, Nov 17 '14 at 12:35
@Naincy Gupta,I tried and that lead me to ask of your help here ... — Abu Bakkar Siddique, Nov 17 '14 at 14:26

Mohamad Attat · Accepted Answer · 2014-11-19T10:31:51.910

1

suppose that the list of cities is an array $cities then

<?php
$counter = 0;

// the list of cities to be printed
$list = "";

foreach($cities as $city) {
    if($counter == count($cities)) {
        $list.= $city;
    } else {
        $list.= $city.",";
    }
        $counter++;
}

echo $list;
?>

edited Nov 19 '14 at 10:31

answered Nov 17 '14 at 12:34

Mohamad Attat

493
2
8

1

Yes, this works, but it's just about the most convoluted code to do it. – deceze Nov 17 '14 at 12:37
@Mohammad Attat, Brother, my codes was in a while loop. After running code that you suggest, shows an error msg "Invalid argument supplied for foreach()". Hope you will reply me. – Abu Bakkar Siddique Nov 17 '14 at 14:23
@AbuBakkarSiddique can you show me the code including the while loop ? – Mohamad Attat Nov 17 '14 at 14:31
@MohamadAttat Yes, latter on I will change to mysqli. '.$city.', '; }?> – Abu Bakkar Siddique Nov 18 '14 at 04:28
@MohamadAttat, Brother, I have edited my codes....waiting for your kind response. – Abu Bakkar Siddique Nov 19 '14 at 05:15
try this @AbuBakkarSiddique `'.$city.', '; } foreach($cities as $city) { if($counter == count($cities)) { $list.= ''.$city.''; } else { $list.= ''.$city.', '; } $counter++; } echo $list; ?>` – Mohamad Attat Nov 19 '14 at 10:30
@MohamadAttat, Brother, you were almost there....result got reverse way...like DhakaDelhi, Mombai,( it seems that first comma id deleted)...Hope you know how to. – Abu Bakkar Siddique Nov 19 '14 at 11:35
my bad, this should work `'.$city.''; } else { $list.= ''.$city.', '; } } echo $list; ?>` – Mohamad Attat Nov 19 '14 at 11:38
@MohamadAttat, Brother, Thank you Brother for your kind try...Hope I can handle the rest. – Abu Bakkar Siddique Nov 19 '14 at 12:19

Remove last comma from a PhP variable(output)

1 Answers1