errors in php code for search box

Question

I have created search box using php and mysql, for that, I have created index.php and search.php files.

And i have created database named as search.

Here is my code:

Index.php:

<html>
<head>
<title>Title of your search engine</title>
</head>
<body>
<form action='search.php' method='GET'>
<center>
<h1>My Search Engine</h1>
<input type='text' size='90' name='search'></br></br>
<input type='submit' name='submit' value='Search source code' ></br></br></br>
</center>
</form>
</body>
</html>

search.php:

<?php
$button = $_GET ['submit'];
$search = $_GET ['search'];
 if(!$button)
echo "you didn't submit a keyword";
else
{
if(strlen($search)<=1)
echo "Search term too short";
else{
echo "You searched for <b>$search</b> <hr size='1'></br>";
mysql_connect("localhost","root","");
mysql_select_db("search");
 $search_exploded = explode (" ", $search);
 foreach($search_exploded as $search_each)
{
$x++;
if($x==1)
$construct .="keywords LIKE '%$search_each%'";
else
$construct .="AND keywords LIKE '%$search_each%'";
 }
 $construct ="SELECT * FROM searchengine WHERE $construct";
$run = mysql_query($construct);
 $foundnum = mysql_num_rows($run);
 if ($foundnum==0)
echo "Sorry, there are no matching result for <b>$search</b>.</br></br>1.
Try more general words. for example: If you want to search 'how to create a website'
then use general keyword like 'create' 'website'</br>2. Try different words with similar
 meaning</br>3. Please check your spelling";
else
{
echo "$foundnum results found !<p>";
 while($runrows = mysql_fetch_assoc($run))
{
$title = $runrows ['title'];
$desc = $runrows ['description'];
$url = $runrows ['url'];

echo "
<a href='$url'><b>$title</b></a><br>
$desc<br>
<a href='$url'>$url</a><p>
";
 }
}
 }
}
 ?>

When will run this code, it shows following errors,

Notice: Undefined variable: x in C:\xampp\htdocs\selva\search\search.php on line 21

Notice: Undefined variable: construct in C:\xampp\htdocs\selva\search\search.php on line 23

Warning: mysql_num_rows() expects parameter 1 to be resource, boolean given in C:\xampp\htdocs\selva\search\search.php on line 32

can anyone help to fix this, Thanks in advance.

The first two errors are self-evident: you should trace those yourself. the last you could find easily on Google, but look [here](http://stackoverflow.com/questions/2973202/mysql-fetch-array-expects-parameter-1-to-be-resource-or-mysqli-result-boole) — , Nov 08 '14 at 10:00
initialize variable x and $construct. Assign $x = 0;$construct = '' — Captain Planet, Nov 08 '14 at 10:03
@Arif_suhail_123: in php there is no need to initialize the variables right? am i right? — deepika, Nov 08 '14 at 10:05
@deepika mysql_query() returns false if the query failed. That's why mysql_num_rows() complains about receiving a boolean value. — Amal, Nov 08 '14 at 10:06
@Arif_suhail_123: i am not doing myself, i tried using goole. — deepika, Nov 08 '14 at 10:20

score 0 · Answer 1 · answered Nov 08 '14 at 10:03

0

Try, Define

 $x = 0; 
 $construct = '';

before the foreach loop.

mysql_query() returns false if the query failed. That's why mysql_num_rows() complains about receiving a boolean value.

answered Nov 08 '14 at 10:03

Amal

546
6
19

i am asking what about warning / – deepika Nov 08 '14 at 10:06
ok @amal: how to fix this one? – deepika Nov 08 '14 at 10:09
@Arif_suhail_123: help me to fix this – deepika Nov 08 '14 at 10:12
@deepika First do mysql_num_rows only if $run is not false. Then check the query to see whats wrong with it. Meanwhile, mysql driver is deprecated and PDO is recommended. – Amal Nov 08 '14 at 10:16
@Arif_suhail_123: what is op? – deepika Nov 08 '14 at 10:16
@Arif_suhail_123: now it shows no errors.,, but whenever search keyword, always shows no keywords are found.. – deepika Nov 08 '14 at 12:03

errors in php code for search box

1 Answers1