Fail in establishing connection : PHP

Question

I created php script called functions.php in which i've written following codes. It's working fine when i've written "$conn = mysql_connect('localhost','root','pass');" this line. But i want to store these credentials in config file so that it becomes quite easy for me to edit details while working with db. So i created config.php and have written following codes :

<?php
// this is config.php
$config = array(

    'host'=> 'localhost'
    'username' => 'root' ,
    'password' => 'pass' ,
    'database' => 'sample'
);
?>

This is functions.php

<?php
include 'config.php';
function connect($config) {
    $conn = mysql_connect($config['host'],$config['username'],$config['password']);
    return $conn;
}

$con = connect();
if(!$con) die ('problem in connection');

But when i did this then its not working. How can i fix this? Plzz hlp

this is prone to sql injection, use PDO. http://wiki.hashphp.org/PDO_Tutorial_for_MySQL_Developers — Dale, Oct 20 '14 at 07:59
all answers are working correctly, so do i have to accept all answers?? guys m new in stackoverflow plzz tell — Raunak Hajela, Oct 21 '14 at 07:28

score 0 · Answer 1 · answered Oct 20 '14 at 07:53

0

Your syntax is incorrect, try this:

<?php
// this is config.php
$config = array(

    'host'=> 'localhost',     // Missing comma
    'username' => 'root' ,
    'password' => 'pass' ,
   'database' => 'sample'
);
?>

Also, you don't need to pass $config to function, it will be available globally.

answered Oct 20 '14 at 07:53

Rohit Aggarwal

650
8
18

tried but its showing error "problem in connection"... now wat to do?? – Raunak Hajela Oct 21 '14 at 07:12
make sure your username, password is correct, and your mysql engine is working... – Rohit Aggarwal Oct 21 '14 at 07:14
bro got it , i haven't passed $config to my function connect... now its working correctly...thnxx anyway – Raunak Hajela Oct 21 '14 at 07:20

score 0 · Answer 2 · answered Oct 20 '14 at 07:54

0

Why did you add the $config parameter to the connect function? You are not passing any parameter, so $config is always null in your function. Adding the parameter to your call should solve the problem.

$con = connect($config);

answered Oct 20 '14 at 07:54

Jerodev

31,061
11
83
102

thanxx bro this is also working correctly... m using webmatrix while working with php, its not showing any errors if did something wrong... so is der any way to fix this..?? – Raunak Hajela Oct 21 '14 at 07:17

score 0 · Answer 3 · answered Oct 20 '14 at 07:55

0

Change your config.php to:

<?php
// this is config.php
$config = array(

    'host'=> 'localhost', // comma was missing
    'username' => 'root' ,
    'password' => 'pass' ,
    'database' => 'sample'
);
?>

And functions.php to:

<?php
include 'config.php';
function connect($config) {
    $conn = mysql_connect($config['host'],$config['username'],$config['password']);
    return $conn;
}

$con = connect($config);        // You need to pass $config variable when calling function
if(!$con) die ('problem in connection');

answered Oct 20 '14 at 07:55

Apul Gupta

3,023
3
21
30

yeah ryt and thnxx... hv a nyc day :-) – Raunak Hajela Oct 21 '14 at 07:17
Accept my answer if this helped. :) – Apul Gupta Oct 21 '14 at 07:26

score 0 · Accepted Answer · answered Oct 20 '14 at 08:04

I like to suggest the below code. Instead of array values, I would define variables in config.php and use it functions.php

config.php

<?php 
     define("DB_HOST", "localhost");
     define("DB_USERNAME", "root");
     define("DB_PASSWORD", "pass");
     define("DB_NAME", "sample");
?>

In functions.php

  include('config.php');
  $conn = mysql_connect(DB_HOST,DB_USERNAME,DB_PASSWORD);

Fail in establishing connection : PHP

4 Answers4