Php form save to database

Question

I not understand why it doesn't work ??? this is my code ,, In register.php

<form  action="register_save.php" method="POST">
<input style="margin-left: 60px;" type="text" name="member_firstname"/>
<input style="margin-left: 10px;" type="text" name="member_lastname" />
<input style="margin-left: 80px;" type="text" name="member_username"  />
<input style="margin-left: 82px;" type="password" name="member_password" />
<input style="margin-left: 30px;" type="password" name="member_password_confirm" />
<button class="uk-button uk-button-success" type="submit">
        <i class="uk-icon-share-square"></i>
</button>
</form>

In registe_save.php

<?php
    ob_start();

    include_once "../connect.php";

    $member_firstname = $_POST["member_firstname"];
    $member_lastname = $_POST["member_lastname"];
    $member_username = $_POST["member_username"];
    $member_password = $_POST["member_password"];
    $member_password_confirm = $_POST["member_password_confirm"];

    $sql = "INSERT INTO tb_member(member_firstname, member_lastname, member_username, member_password)
                VALUES('$member_firstname','$member_lastname','$member_username','$member_password')"

        if(mysql_query($sql) {

            header("location: template.php?url=register_complete");
        }

?>

when i submit, Page will run to register_save.php but nothing happened and data not save to database

why...?

**Danger**: You are using [an **obsolete** database API](http://stackoverflow.com/q/12859942/19068) and should use a [modern replacement](http://php.net/manual/en/mysqlinfo.api.choosing.php). You are also **vulnerable to [SQL injection attacks](http://bobby-tables.com/)** that a modern API would make it easier to [defend](http://stackoverflow.com/questions/60174/best-way-to-prevent-sql-injection-in-php) yourself from. — Quentin, Sep 13 '14 at 07:52
try `'".$member_firstname."'` insted of `'$member_firstname'` as in all field — Code Baba, Sep 13 '14 at 07:54
This code has an obvious syntax error. Why can't people learn to do common sense debugging? — Salman A, Sep 13 '14 at 08:01

Quentin · Answer 1 · 2014-09-13T08:02:16.977

1

if(mysql_query($sql) {

You have unmatched parenthesis.

You also have a missing ; from the end of the line starting $sql =.

Both these errors should have been reported in your error log file. You should look at it.

edited Sep 13 '14 at 08:02

answered Sep 13 '14 at 07:53

Quentin

857,932
118
1,152
1,264

score 0 · Answer 2 · answered Sep 13 '14 at 07:59

try this:

<?php
    ob_start();

    include_once "../connect.php";

    $member_firstname = $_POST["member_firstname"];
    $member_lastname = $_POST["member_lastname"];
    $member_username = $_POST["member_username"];
    $member_password = $_POST["member_password"];
    $member_password_confirm = $_POST["member_password_confirm"];

    $sql = "INSERT INTO tb_member(member_firstname, member_lastname, member_username, member_password) VALUES('$member_firstname','$member_lastname','$member_username','$member_password')";

        if(mysql_query($sql) {

            header("location: template.php?url=register_complete");
        }

?>

Where is the semi-colon missing? – Quentin Sep 13 '14 at 08:01 — Quentin, Sep 13 '14 at 08:01

score 0 · Answer 3 · answered Sep 13 '14 at 08:32

you missed ) and ;

replace

 $sql = "INSERT INTO tb_member(member_firstname, member_lastname, member_username,  member_password) VALUES('$member_firstname','$member_lastname','$member_username','$member_password')"

to

 $sql = "INSERT INTO tb_member(member_firstname, member_lastname, member_username, member_password) VALUES('$member_firstname','$member_lastname','$member_username','$member_password')";

and

if(mysql_query($sql) {

to

if(mysql_query($sql)) {

Php form save to database

3 Answers3