error C2504: base class undefined

Question

I have encountered this error many times before and eventually found solutions, but this one has me stumped. I have a class 'Mob' that is inherited by class 'Player'. This is Mob.h:

#pragma once
#include "PlayState.h"
#include "OmiGame/OmiGame.h"
#include "resources.h"

class PlayState;

class Mob
{
private:
    int frames;
    int width;
    int height;
    int time;

    sf::Texture textureL;
    sf::Texture textureR;
    Animation animationL;
    Animation animationR;
    AnimatedSprite sprite;
    bool moveLeft;
    bool moveRight;
    bool facingRight;

public:
    void createMob(std::string l, std::string r, int frames, int width, int height, int time, int x, int y);

    void updateMob(omi::Game *game, PlayState *state);
    void drawMob(sf::RenderTarget &target);

    void setLeft(bool b) { moveLeft = b; }
    void setRight(bool b) { moveRight = b; }
    bool isLeft() { return moveLeft; }
    bool isRight() { return moveRight; }

    sf::Vector2f getPosition() { return sprite.getPosition(); }
};

This is Player.h, as of now it is extremely simple:

#pragma once
#include "OmiGame/OmiGame.h"
#include "PlayState.h"
#include "Mob.h"
#include "resources.h"

class PlayState;
class Mob;

const int playerFrames = 8;
const int playerWidth = 16;
const int playerHeight = 48;
const int playerTime = 50;
const int playerX = 200;
const int playerY = 200;

class Player : public Mob
{ //the error occurs at this line//
public:
    Player();
    void update(omi::Game *game, PlayState *state);
    void draw(sf::RenderTarget &target);
};

And, as you can probably guess, this is the error:

error C2504: 'Mob' : base class undefined   player.h

I have forward declared mob, I have hopefully fixed any circular dependencies. Please can someone help me?

You know, it somehow defeats encapsulation if you provide accessors for all your private members... — Deduplicator, Jul 13 '14 at 18:11
@Deduplicator It doesn't. Only four private members have accessors because mobs need to react differently based on them, yet they need to share these members so the reused code can also access them. — Greg Treleaven, Jul 13 '14 at 20:56
@Greg: So they are public members, even though the code tries to deceive you into believing otherwise. — Deduplicator, Jul 13 '14 at 21:14
@Deduplicator True, the getter/setter coding style is controversial, but I learned OO programming that way so it's become a habit. It's all down to personal preference and convention. — Greg Treleaven, Jul 13 '14 at 21:29

score 31 · Accepted Answer · answered Jul 13 '14 at 18:29

31

Forward declaring doesn't help for class Player : public Mob because the compiler needs the full definition for inheritance.

So most likely one of your includes in Mob.h is bringing in Player.h which then puts Player ahead of Mob and thus triggers the error.

answered Jul 13 '14 at 18:29

TheUndeadFish

7,880
1
21
16

2

Removing `#include "PlayState.h"` worked. PlayState declares Player, but Player also declares PlayState so the line wasn't needed. Thanks. – Greg Treleaven Jul 13 '14 at 19:05

score 11 · Answer 2 · edited May 23 '17 at 10:29

I have got through the similar problem and I out solution and made it a thumb rule for me

Solution / Thumb Rule

//File - Foo.h
#include "Child.h"
class Foo 
{
//Do nothing 
};

//File - Parent.h
#include "Child.h" // wrong
#include "Foo.h"   // wrong because this indirectly 
                   //contain "Child.h" (That is what is your condition)
class Parent 
{
//Do nothing 
Child ChildObj ;   //one piece of advice try avoiding the object of child in parent 
                   //and if you want to do then there are diff way to achieve it   
};

//File - Child.h
#include "Parent.h"
class Child::public Parent 
{
//Do nothing 
};

Don't include the child in parent class .

if you want to know the way to have a child object in a parent class the refer the link Alternative

Thank you

score 1 · Answer 3 · answered Dec 10 '17 at 10:10

1

I know this is not the best way to deal with that problem, but it work for me at least. you can put all your other includes in the cpp file:

#include "OmiGame/OmiGame.h"
#include "PlayState.h"
#include "Mob.h"
#include "resources.h"

answered Dec 10 '17 at 10:10

Mark green

43
9

error C2504: base class undefined

3 Answers3

Linked

Related