How to make a replaceAll function in JavaScript?

Question

Currently I am trying to make a function in JavaScript that takes three arguments;
1. Template String
2. Word To Replace
3. Word To Replace With

Here's what I tried:

function replaceAll(templateString, wordToReplace, replaceWith)
{
    var regex = new RegExp("/" + wordToReplace + "/","g");
    return templateString.replace(regex, replaceWith);
}

console.log(replaceAll('My name is {{MyName}}', '{{MyName}}', 'Ahmed'));

But it's still giving me the templateString back. Without replacing.
This is what I got back: My name is {{MyName}}

`/` designates the opening and closing of regex literal syntax. There's no need for it when building the regex from a string. — cookie monster, Jun 17 '14 at 01:54
...and I'm not sure what you're trying to do with `return replacedString = `. Is `replacedString` a variable that is used somewhere? — cookie monster, Jun 17 '14 at 01:56
@cookie monster first I saved the result in a var. But then I decided to just return it directly. My fault. Now I've corrected it in my question. — Faiz Ahmed Rana, Jun 17 '14 at 02:21

score 0 · Answer 1 · answered Jun 17 '14 at 01:57

0

Here's a way without using Regex.

var replaceAll = function(tmpString, wordToReplace, wordToReplaceWith){
  return tmpString.split(wordToReplace).join(wordToReplaceWith);
}

replaceAll(str, '{{MyName}}', 'Ahmed'); //    "My name is Ahmed"

answered Jun 17 '14 at 01:57

Tyler McGinnis

33,715
16
71
75

stephenspann · Accepted Answer · 2014-06-17T12:41:44.207

0

Your code is correct, except you don't need the beginning and ending '/' when using the class RegExp:

function replaceAll(templateString, wordToReplace, replaceWith)
{
    var regex = new RegExp(wordToReplace,"g");
    return replacedString = templateString.replace(regex, replaceWith);
}

console.log(replaceAll('My name is {{MyName}}', '{{MyName}}', 'Ahmed'));

edited Jun 17 '14 at 12:41

answered Jun 17 '14 at 02:01

stephenspann

1,733
1
14
31

How to make a replaceAll function in JavaScript?

2 Answers2