Sql result returning as a boolean not resource

Question

The following is the php code, and I will cut in to explain where the errors occur

//getting the aisles for the list via mysql query
for($i = 0; $i < $size; $i++){

size is the count of a previous array

$sql = "SELECT Aisle FROM `Items` WHERE `Store_ID` = $storeid AND `Name`= {$items[$i]}";
print("i=$i");
$result= mysql_query($sql, $link);
print("'items[$i]' is $items[$i]");
print("$sql");

$temp= mysql_fetch_assoc($result);

result is being returned as a boolean

$aisle= $temp["Aisle"];
$aisles[$i] = $aisle;
print(current($aisles));
mysql_free_result($result);
}

here is the error code

5SELECT storeid FROM ListNames WHERE user_id = 1 AND listname='test'2i=0'items[0]' is SELECT Aisle FROM Items WHERE Store_ID = 2 AND Name= Warning: mysql_fetch_assoc() expects parameter 1 to be resource, boolean given in /home2/ctshaw96/public_html/scripts/getAisles.php on line 66

Warning: mysql_free_result() expects parameter 1 to be resource, boolean given in /home2/ctshaw96/public_html/scripts/getAisles.php on line 70 i=1'items[1]' is SELECT Aisle FROM Items WHERE Store_ID = 2 AND Name= Warning: mysql_fetch_assoc() expects parameter 1 to be resource, boolean given in /home2/ctshaw96/public_html/scripts/getAisles.php on line 66

Warning: mysql_free_result() expects parameter 1 to be resource, boolean given in /home2/ctshaw96/public_html/scripts/getAisles.php on line 70 i=2'items[2]' is SELECT Aisle FROM Items WHERE Store_ID = 2 AND Name= Warning: mysql_fetch_assoc() expects parameter 1 to be resource, boolean given in /home2/ctshaw96/public_html/scripts/getAisles.php on line 66

Warning: mysql_free_result() expects parameter 1 to be resource, boolean given in /home2/ctshaw96/public_html/scripts/getAisles.php on line 70 i=3'items[3]' is SELECT Aisle FROM Items WHERE Store_ID = 2 AND Name= Warning: mysql_fetch_assoc() expects parameter 1 to be resource, boolean given in /home2/ctshaw96/public_html/scripts/getAisles.php on line 66

Warning: mysql_free_result() expects parameter 1 to be resource, boolean given in /home2/ctshaw96/public_html/scripts/getAisles.php on line 70 i=4'items[4]' is SELECT Aisle FROM Items WHERE Store_ID = 2 AND Name= Warning: mysql_fetch_assoc() expects parameter 1 to be resource, boolean given in /home2/ctshaw96/public_html/scripts/getAisles.php on line 66

Warning: mysql_free_result() expects parameter 1 to be resource, boolean given in /home2/ctshaw96/public_html/scripts/getAisles.php on line 70 "Item Not Found""Item Not Found""Item Not Found""Item Not Found""Item Not Found"

and here is the url http://shaw-dev.com/scripts/getAisles.php?userid=1&listname=test

So what you should do is go to the manual page and see what it means that the function returned a boolean. Or you can just click any of the similarly named questions on the right. — Jon, Jun 03 '14 at 17:19
Your DB connection wouldn't happen to be `mysqli_` now, would it? — Funk Forty Niner, Jun 03 '14 at 17:19

score 1 · Answer 1 · edited May 23 '17 at 11:49

This SQL:

SELECT Aisle FROM `Items` WHERE `Store_ID` = $storeid AND `Name`= {$items[$i]}

will build incorrect SQL such as

SELECT Aisle FROM `Items` WHERE `Store_ID` = $storeid AND `Name`= foo

It must be put in single quotes.

However, please note that building SQL statements with outside variables makes your code vulnerable to SQL injection attacks. Also, any input data with single quotes in it, like "O'Malley", will blow up your query. Learn about parametrized queries, preferably with the PDO module, to protect your web app. This question has many detailed examples. See also http://bobby-tables.com/php for alternatives & explanation of the danger. Running SQL statements built with outside data is like eating soup made from ingredients found on your doorstep.

score 0 · Answer 2 · answered Jun 03 '14 at 17:19

0

mysql_query() will return false if there's an error.

If it returns false, you can get the error message with mysql_error().

answered Jun 03 '14 at 17:19

41eight

191
5

score 0 · Answer 3 · answered Jun 03 '14 at 17:22

0

wrap item[$i] with single quotes

$sql = "SELECT Aisle FROM `Items` WHERE `Store_ID` = $storeid AND `Name`= '{$items[$i]}'";

answered Jun 03 '14 at 17:22

ɹɐqʞɐ zoɹǝɟ

4,282
3
19
35

Sql result returning as a boolean not resource

3 Answers3