PHP doesn't want to inserting to database

Question

What am I doing wrong with this code?

<?php

/*
 * Following code will create a new product row
 * All product details are read from HTTP Post Request
 */
 mysql_select_db("dataparkir");
 $con = mysql_connect("localhost","root","") or die("error connection");
 if($con)
 {
    echo "connection success";
 }

    // check for required fields
    $lantai = $_POST['lantai'];
    $waktu_masuk = $_POST['waktu_masuk'];
    $waktu_keluar= $_POST['waktu_keluar'];
    $id_user = $_POST['id_user'];
    $qr_code = $_POST['qr_code'];
    //echo "input data: " . $lantai." ".$waktu_masuk." ".$waktu_keluar." ".$id_user." ".$qr_code." ";

    // mysql inserting a new row
    $result = mysql_query($con,"INSERT INTO transaksi (lantai, waktu_masuk, waktu_keluar, id_user, qr_code) VALUES($lantai, $waktu_masuk, $waktu_keluar, $id_user,'$qr_code')");

    // check if row inserted or not
    if ($result) {
        echo mysql_insert_id();
    } else {
        echo '0';
    }

?>

Because yesterday, I was running this code and all fine, but this morning, I run this code and i got "connectionsuccess0" on my code, which means it isn’t do $result, why is that?

table schema :

1   id_transaksi    int(11)     
2   waktu_masuk int(11)     
3   waktu_keluar    int(11)     
4   lantai  varchar(40) 
5   tempat_parkir   varchar(40) 
6   qr_code varchar(40)     
7   id_user int(11) 

Answer 1

There's so many things wrong with this code...

1. Using the deprecated and unmaintained mysql extension
2. Calling mysql_select_db before you have a connection
3. SQL injection vulnerabilities
4. No error checking

Get with the times

// I'm going to assume you can add some verification around these POST params.
// Here's a simple check
if (!isset($POST['lantai'], $_POST['waktu_masuk'], $_POST['waktu_keluar'], $_POST['id_user'], $_POST['qr_code'])) {
    throw new Exception('Not all required POST parameters are set. ' . print_r($_POST, true));
}

$lantai = $_POST['lantai'];
$waktu_masuk = $_POST['waktu_masuk'];
$waktu_keluar= $_POST['waktu_keluar'];
$id_user = $_POST['id_user'];
$qr_code = $_POST['qr_code'];

$con = new mysqli('localhost', 'root', '', 'dataparkir');
if ($con->connect_errno) {
    throw new Exception($con->connect_error, $con->connect_errno);
}
$con->set_charset('utf8'); // change if not appropriate

if (!$stmt = $con->prepare('INSERT INTO transaksi (lantai, waktu_masuk, waktu_keluar, id_user, qr_code) VALUES (?, ?, ?, ?, ?)')) {
    throw new Exception($con->error, $con->errno);
}

$stmt->bind_param('siiis', $lantai, $waktu_masuk, $waktu_keluar, $id_user, $qr_code);

if (!$stmt->execute()) {
    throw new Exception($stmt->error, $stmt->errno);
}
echo $con->insert_id;

Answer 2

Are you sure you're using mysql_query instead of mysqli_query. Try changing all of mysql_query into mysqli_query because example for this one:

$result = mysql_query($con,"INSERT INTO transaksi (lantai, waktu_masuk, waktu_keluar, id_user, qr_code) VALUES($lantai, $waktu_masuk, $waktu_keluar, $id_user,'$qr_code')");

it should be

$result = mysqli_query($con,"INSERT INTO transaksi (lantai, waktu_masuk, waktu_keluar, id_user, qr_code) VALUES($lantai, $waktu_masuk, $waktu_keluar, $id_user,'$qr_code')");

mysql_query takes 1st parameter as query and 2nd parameter as connection.

mysqli_query takes 1st parameter as the connection and 2nd parameter as query.

mysql_query is deprecated so it is advisable to use mysqli_query