error in objects source with JavaScript

Question

This is my first time to make an object in JS.

Can someone help me understand why the sourve did not work?

this is the full source:

<script>
function person(firstname,lastname,age,eyecolor) {
    this.firstname=firstname;
    this.lastname=lastname;
    this.age=age;
    this.eyecolor=eyecolor;

    function getName() {
        return this.firstname;
    }
}

var myFather = new person("John","Doe",50,"blue");
document.write( myFather.getName() );
</script>

score 0 · Accepted Answer · answered Mar 26 '14 at 07:38

0

function getName() {
    return this.firstname;
}

should be

this.getName = function () {
    return this.firstname;
}

And it's better to attach such method to the prototype of person.

person.prototype.getName = function () {
    return this.firstname;
}

answered Mar 26 '14 at 07:38

xdazz

154,648
35
237
264

can u explain it a bit why? – Zaheer Ahmed Mar 26 '14 at 07:41
@ZaheerAhmed it's a bit of a long story but this may help out: http://stackoverflow.com/a/16063711/1641941 – HMR Mar 26 '14 at 13:24

score 0 · Answer 2 · answered Mar 26 '14 at 07:53

0

here is the code.

<script>
function person(firstname,lastname,age,eyecolor) {
    this.getName =  function getName() {
        return firstname;
    }
}

document.write( (new person("John","Doe",50,"blue")).getName() );
</script>

answered Mar 26 '14 at 07:53

Muhammad Irfan

238
1
8

error in objects source with JavaScript

2 Answers2