PHP mysql_query string error

Question

I am trying to work with databases on PHP, however I am getting an error when I try to make a table of data. The table seems to be created correctly (I think) but when I want to print the confirmation of the table is created, it throws me an error. This is the code:

   if (mysql_query($connection,$sql)) //error
   {
      echo "1 record added";
   }
   else
   {
      die('Error: ' . mysql_error($con)); //error
   }

They both give me the error mysql_query() expects parameter 1 to be string and mysql_error() expects parameter 1 to be resource

Where $sql - the info being put in the table

the error says that the function `mysql_query() expects parameter 1 to be string`. Are you sure that variables `$connection` and `$sql` are string? — Vainglory07, Feb 17 '14 at 01:39
Why is it called `$connection` first` and `$con` second? And why didn't you just try switching parameter order for the first? Isn't the error message clear? — mario, Feb 17 '14 at 01:39
You are calling `mysql_query()` like `mysqli_query()`, which takes a resource as its first param. — Michael Berkowski, Feb 17 '14 at 01:39
Are people still using `mysql` functions? Please, get with the times and use `mysqli` or `pdo`. — Christian, Feb 17 '14 at 01:40
[Why shouldn't I use mysql_* functions in PHP?](http://stackoverflow.com/questions/12859942/why-shouldnt-i-use-mysql-functions-in-php) — Phil, Feb 17 '14 at 01:52

score 1 · Accepted Answer · edited Feb 17 '14 at 01:52

1

That won't work because mysql_query only returns a boolean based on if the query failed to execute or not (i.e. SQL syntax error).

You'll need to use mysql_affected_rows instead.

mysql_query($sql);
if(mysql_affected_rows()) {
    echo "1 record added";
}

Please take note of the scary red box on that page. mysql_query is deprecated. You need to switch to mysqli

edited Feb 17 '14 at 01:52

Phil

141,914
21
225
223

answered Feb 17 '14 at 01:39

Machavity

29,816
26
86
96

+1 for the comment about `mysql` functions, I can't believe are still trying to use `mysql` in new projects. – Christian Feb 17 '14 at 01:42
how do you know its new ? – Feb 17 '14 at 01:46
I took your advice to switch to `mysqli` but now it is expecting a mysqli parameter. What exactly is a mysqli parameter? – user1404664 Feb 17 '14 at 01:50
You will have to switch all your functions to `mysqli`, not just one – Machavity Feb 17 '14 at 03:11

score 0 · Answer 2 · answered Feb 17 '14 at 01:57

$server = 'localhost';  
$username   = 'root';  
$password   = 'YOUR PASSWORD';  
$database   = 'DB_name';  
$con = mysql_connect($server, $username,$password);
$db = mysql_select_db($database);
if(!$con)  
{  
    exit('Error: could not establish database connection');  
}  
if(!$db)  
{  
    exit('Error: could not select the database');  
} 
$sql ="CREATE TABLE Persons(FirstName CHAR(30),LastName CHAR(30),Age INT)";
$result = mysql_query($sql);
if (!$result) //error
   {
     echo mysql_error(); //error
   }
   else
   {
      echo "1 record added"; 
   }

PHP mysql_query string error

2 Answers2