PHP Mysql login problems

Question

Warning: mysql_num_rows() expects parameter 1 to be resource, boolean given in N:\ftp\compc\d10cn\Project\login1.php on line 51
The username you entered was not found.

^^ this is the error i keep getting, does anyone know what this means? or what would be wrong with line 51, which is:

$query = mysql_query ("SELECT * FROM users WHERE username = '$user'");

$numrows = mysql_num_rows($query);
if ($numrows == 1){

It's likely that your `$query` is being set to false which means that your query has an error or possibly the space between the function call `mysql_query ()`. `mysql_num_rows($query);` is throwing the error since you're passing `false (BOOLEAN)` as the parameter. Also, you should avoid using `mysql` functions in the first place -- use `mysqli` or `PDO`. — sbeliv01, Jan 29 '14 at 17:43
Can i make a suggestion too. Don't use the mysql_ set of functions, they're deprecated. Use mysqli_ or even better use the PDO functions. — Garry Welding, Jan 29 '14 at 17:43
Please stop using `mysql_*` functions as they have been depcrated. You really should use PDO or `mysqli_*` functions. — Anil Natha, Jan 29 '14 at 17:44
*The username you entered was not found.* Are you sure the username you're using as parameter is stored in the table? — Sebastian, Jan 29 '14 at 17:46
if ($_POST ['loginbtn']) { $user = $_POST ['user']; $password = $_POST ['password']; if ($user) { if ($password) { require("dbConnect.php"); $password=md5 (md5("hufnrfne".$password."rgtrbgrt")); //make sure login info correct $query = mysql_query("SELECT * FROM users WHERE username = '$user'"); $numrows = mysql_num_rows($query); if ($numrows == 1){ $row = mysql_fetch_assoc($query); $dbid = $row ['id']; $dbuser = $row ['username']; $dbpass = $row ['password']; $dbactive = $row ['active']; — Niamh2, Jan 29 '14 at 17:51
if ($password == $dbpass) { if ($dbactive == 1) { // set session info $_SESSION ['userid'] = $dbid; $_SESSION ['username'] = $dbuser; echo "You have been logged in as $dbuser. Click here to go to the members area"; } else echo "You must activate your account to log in. $form"; } else echo "You did not enter the correct password. $form"; } else echo "The username you entered was not found. $form"; mysql_close(); } else echo "You must enter your password. $form"; } else echo "You must enter your username. $form"; } else echo $form; — Niamh2, Jan 29 '14 at 17:51
That is my whole code, I couldnt put it into my question because it was not indented, could someone have a look at it in a text editor please? i still can not get passed this part! my code is in three comments — Niamh2, Jan 29 '14 at 17:52

score 1 · Answer 1 · answered Jan 29 '14 at 17:43

please try like so

    <?php 
    $link = mysql_connect("host", "username", "password");
    mysql_select_db("database", $link);

    $result = mysql_query("SELECT * FROM users WHERE username = '$user'", $link);
    $num_rows = mysql_num_rows($result);
    echo $num_rows

    ?>

Saurabh Sharma · Answer 2 · 2014-01-29T18:02:15.453

1

Check $query before passing it to mysql_fetch_array. You'll find that it's false because the query failed. See the [mysql_query][1] documentation for possible return values and suggestions for how to deal with them.

$query = mysql_query("SELECT * FROM users WHERE username = '$user'");

if($query === FALSE) {
    die(mysql_error()); // TODO: better error handling
}

$numrows = mysql_num_rows($query);
if ($numrows == 1){

edited Jan 29 '14 at 18:02

answered Jan 29 '14 at 17:43

Saurabh Sharma

2,384
4
19
37

thank you that got rid of the error although it will not recognise my user name which is stored in the database???i have posted my code above – Niamh2 Jan 29 '14 at 17:57
It will ! but the result is being retrieved in `$result` now make sure that you are using the correct variable – Saurabh Sharma Jan 29 '14 at 18:01
Anyways @Niamh2 I updated my answer matching your code variables. Try it now – Saurabh Sharma Jan 29 '14 at 18:03

PHP Mysql login problems

2 Answers2