Check Text File Length In C

Question

I have a text file, which has random amount of characters, numbers, spaces and new lines. I'm trying to figure out how to find the "length" of this file. For example: if the text file contains "This is an example." the lenght should be 19. I tried using both sizeof(text_file) and strlen(text_file), but they don't give me the desired output.

What I also tried was this:

 void test(FILE *f){


  int i;
  i=0;
  char ch;
  while( ( ch = fgetc(f) ) != EOF )
{
   printf("%c",ch);    /*This is just here to check what the file contains*/
   if(ch!='\0')        
   {
       i=i+1;
   }


}
printf("------------------\n");
printf("The length of the file is\n");
printf("%d",i);   /*For some reason my length is always +1 what it actually should be*\
}

Is there an easier way to do this and why does the code above always give +1? I guess there is something wrong with the if statement, but I don't know what.

Any help is really appreciated thanks in advance.

`fseek(f, 0, SEEK_END); size_t length = ftell(f);` should to the job. — , Jan 12 '14 at 11:31
I don't think this counts as a duplicate. The other answer asked for a file in general (for which the fseek / ftell is not a portable solution), whereas this specifically asked for text files. — CoffeeTableEspresso, Nov 15 '18 at 00:53

score 3 · Answer 1 · edited May 23 '17 at 11:43

3

As others have already explained, there are better ways to determine a file size.

The reason that your code does not give the expected result is probably that your file contains a trailing newline character \n which is counted as well:

This is an example.\n

are 20 characters, not 19.

And note that you should declare int ch, not char ch for the EOF-check to work properly, compare fgetc, checking EOF.

edited May 23 '17 at 11:43

Community

1
1

answered Jan 12 '14 at 11:49

Martin R

510,973
84
1,183
1,314

Fixed it now and the code works properly, thanks. – roneboy Jan 12 '14 at 11:57

Devolus · Accepted Answer · 2014-01-12T11:42:27.903

2

As for the size you can do this:

 size_t pos = ftell(f);    // Current position
 fseek(f, 0, SEEK_END);    // Go to end
 size_t length = ftell(f); // read the position which is the size
 fseek(f, pos, SEEK_SET);  // restore original position

If you don't care about the position, you can of course omit resetting the current filepointer.

edited Jan 12 '14 at 11:42

answered Jan 12 '14 at 11:34

Devolus

21,012
12
62
109

2

Note that this can only be relied on with files opened in binary mode, and even then there may be [other potential issues](https://www.securecoding.cert.org/confluence/display/seccode/FIO19-C.+Do+not+use+fseek%28%29+and+ftell%28%29+to+compute+the+size+of+a+regular+file). Though it's a good quick solution, unfortunately extra libraries are needed to do this properly (i.e. abstractions such as `Boost.Filesystem`, Qt's `QFile`, or simply accessing the OS directly with [`stat`](http://pubs.opengroup.org/onlinepubs/009695399/functions/stat.html).) You probably know this, but it's worth noting. – John Chadwick Jan 12 '14 at 11:38

Check Text File Length In C

2 Answers2