50

How can I compare two C++11 std::functions with operator==, and return true if both of said functions refer to the same function pointer?

JesseTG
  • 1,883
  • 1
  • 20
  • 44

6 Answers6

25

operator== for std::function compares a std::function with a null pointer, as far as I can tell the standard does not provide any details as to why.

Although, this boost FAQ entry, Why can't I compare boost::function objects with operator== or operator!=? provides a rationale and as far as I can tell should be applicable to std::function as well. Quoting the FAQ:

Comparison between boost::function objects cannot be implemented "well", and therefore will not be implemented. [...]

it then outlines requested solutions similar to Preet's and goes on to say:

The problem occurs when the type of the function objects stored by both f and g doesn't have an operator==[...]

and explains why this has to has to be dealt with in either the assignment operator or constructor and then goes on to say:

All of these problems translate into failures in the boost::function constructors or assignment operator, even if the user never invokes operator==. We can't do that to users.

Update

Found a standards rationale in Accessing the target of a tr1::function object, which is pretty old but is consistent with the boost FAQ and says:

operator== is unimplementable for tr1::function within the C++ language, because we do not have a reliable way to detect if a given type T is Equality Comparable without user assistance.

Shafik Yaghmour
  • 148,593
  • 36
  • 425
  • 712
18

You can actually get it to work with .target:

template<typename T, typename... U>
size_t getAddress(std::function<T(U...)> f) {
    typedef T(fnType)(U...);
    fnType ** fnPointer = f.template target<fnType*>();
    return (size_t) *fnPointer;
}

if (getAddress(f) == getAddress(g)) {...}

(Ref: C++ trying to get function address from a std::function)

Community
  • 1
  • 1
P i
  • 26,994
  • 34
  • 144
  • 244
  • Magic, thanks. For some reason my attempts at this without templating returned different function pointers for two std::function wrappers of the same function. Curious! – andybuckley Apr 19 '16 at 09:37
  • 2
    Converting function pointer to `size_t` is conditionally-supported with implementation-defined semantics. So this solution may not be portable. – M.M Dec 13 '17 at 03:45
  • 3
    This only works if the wrapped object is a function pointer, not if it is a callable class or one of several other things that can be wrapped by a `std::function` – Baruch Jan 14 '18 at 10:04
  • If you know the type of the target, then perhaps you don't need `std::function` to begin with. – n. 1.8e9-where's-my-share m. Aug 18 '20 at 06:48
5

You could try comparing a and b first by comparing their .target_type() and if these target type ids are the same, then you can compare their .target() pointers. You can use a mismatching target type as an early out false.

Preet Kukreti
  • 8,267
  • 26
  • 36
2

If the std::function<T(U...)> f is a member function,the fnPointer will be null.

yksten
  • 21
  • 3
2

Be aware that equality of functions (deciding if two functions have always the same observable behavior) is an undecidable problem in lambda calculus (and that is why many programming languages forbid comparing functions; or at least closures; two very different functions can have the same observable behavior: for example, rename the variables in the C code of one function by another one, or do manually some loop unrolling, etc...).

So even if the == test compiles, it would at most just test that the code is identical (has the same address), not that the compared functions have the same behaviour.

Basile Starynkevitch
  • 216,767
  • 17
  • 275
  • 509
1

What about comparing two shared_ptr?

using MessageFilter = std::function<void(const int msgID)>;

static void onMessageReceived(const int msgID)
{
    std::cout << "msg id => " << msgID << std::endl;
}

static void someFunc()
{
    auto filter = std::make_shared<MessageFilter>(&onMessageReceived);

    if (filter && *filter)
    {
        (*filter)(1234);
    }
}

As you can see, 'filter' is a shared_ptr, so it is easy to compare with another.

Sanbrother
  • 575
  • 4
  • 12
  • Thank you, we used your suggestion in our [Delegates template library](https://github.com/linksplatform/Delegates/blob/d7e6ee5808daeed70b5f47cc342cfd651de30dd0/cpp/Platform.Delegates/Platform.Delegates.Delegate.h#L92). This way we were able to remove hack code where we were trying to compare std::function byte by byte. Your solution is much simpler and works immediately on all platforms. – Konard Oct 21 '21 at 17:27